Last modified: 2011-06-16 17:37:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31354, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29354 - download as pdf does not take the tag <code> into account
download as pdf does not take the tag <code> into account
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Collection (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: PediaPress Development Team
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-11 22:27 UTC by pranith
Modified: 2011-06-16 17:37 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
downloaded pdf from wikipedia (122.78 KB, application/pdf)
2011-06-11 22:27 UTC, pranith
Details
print-to-pdf from firefox (88.39 KB, application/pdf)
2011-06-11 22:28 UTC, pranith
Details

Description pranith 2011-06-11 22:27:03 UTC
Created attachment 8642 [details]
downloaded pdf from wikipedia

when you download an article on wikipedia as a pdf, it does not take the tag <code> into account. Because of this, the formatting in the pdf is changed compared to the formatting in HTML.

Example:http://en.wikipedia.org/wiki/Knuth%E2%80%93Morris%E2%80%93Pratt_algorithm

The worked examples in the algorithm are all as plain text when viewed in the pdf.

Compare with Print-to-pdf in Firefox which gives similar formatting.
Comment 1 pranith 2011-06-11 22:28:07 UTC
Created attachment 8643 [details]
print-to-pdf from firefox
Comment 2 Sam Reed (reedy) 2011-06-12 09:47:11 UTC
<source></source> works fine though

I'm not sure if this is a dupe, as I remember discussing with someone about this recently.

But that might've been on IRC

There's a couple of very similar related bugs about too
Comment 4 Chad H. 2011-06-14 12:25:10 UTC
I don't know anything about the mwlib software, but just from the context in the diff [0] it looks like you have it backwards. Shouldn't it be "Code: [PreFormatted]" not the other way around?

[0] http://code.pediapress.com/git/mwlib?p=mwlib;a=commitdiff;h=82c91f7ff491961db48fd309866ab7eafb459564
Comment 5 Volker Haas 2011-06-14 12:35:46 UTC
I tested the change and it works. But I agree, the diff (and the "configuration" of "forbidden_parents") looks wrong. When I came up with that type of mapping it probably made sense. But from todays perspective the configuration looks pretty stupid. Maybe I'll change it some day...
Comment 6 Chad H. 2011-06-14 12:45:45 UTC
Fair enough, thanks for clarifying :)
Comment 7 pranith 2011-06-16 17:37:30 UTC
Thanks a lot!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links