Last modified: 2011-11-17 21:27:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31418, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29418 - Name of type "Geographic coordinate" is not localized.
Name of type "Geographic coordinate" is not localized.
Status: VERIFIED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Maps (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Jeroen De Dauw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-15 20:14 UTC by Van de Bugger
Modified: 2011-11-17 21:27 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
The fix. (466 bytes, patch)
2011-06-15 20:14 UTC, Van de Bugger
Details

Description Van de Bugger 2011-06-15 20:14:01 UTC
Created attachment 8666 [details]
The fix.

I am running a server with:

MediaWiki 1.16.5
Maps 0.7.6.1
Semantic MediaWiki 1.5.6
Semantic Maps 0.7.6.1

Default language is Russian ($wgLanguageCode = "ru";). Name of type "Geographic coordinate" is NOT localized, it is still displayed in English language, regardless of the file extensions/SemanticMediaWiki/languages/SMW_LanguageRu.php:

protected $m_DatatypeLabels = array(
   ...
   '_geo' => 'Географическая координата', // name of the geocoord type
   ...

I found the cause of this bug. It is extensions/SemanticMaps/includes/SM_GeoCoordsValue.php file:

public static function initGeoCoordsType() {
    SMWDataValueFactory::registerDatatype( '_geo', __CLASS__, 'Geographic coordinate' );
    return true;
}

If I remove hardcoded type name:

public static function initGeoCoordsType() {
    SMWDataValueFactory::registerDatatype( '_geo', __CLASS__ );
    return true;
}

it will be properly localized depending on language. See attached patch.
Comment 1 Jeroen De Dauw 2011-06-15 20:42:02 UTC
I applied your fix in r90144. It will be in version 0.7.7, which will be released soonish. Thanks for the patch! :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links