Last modified: 2011-06-16 17:58:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31426, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29426 - BlockTest using invalid Block::load calls
BlockTest using invalid Block::load calls
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Unit tests (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Brion Vibber
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-16 00:44 UTC by OverlordQ
Modified: 2011-06-16 17:58 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description OverlordQ 2011-06-16 00:44:19 UTC
2) BlockTest::testBug29116LoadWithEmptyIp with data set #0 (NULL)
3) BlockTest::testBug29116LoadWithEmptyIp with data set #1 ('')
4) BlockTest::testBug29116LoadWithEmptyIp with data set #2 (false)

all give errors with Pg backend due to calling Block as:

$block->load( $vagueTarget, 'UTBlockee' );

the second parameter to load is supposed to be an Integer userid.

This gets passed through all the way to the DB backend which results in a query like:

SELECT user_name  FROM mwuser  WHERE user_id = 'UTBlockee...
Comment 1 Brion Vibber 2011-06-16 17:46:16 UTC
Yeah I see... fixing...
Comment 2 Brion Vibber 2011-06-16 17:58:40 UTC
And all nicely cleaned up in r90219.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links