Last modified: 2011-06-28 00:50:06 UTC
Every time I load a user page, I see the WikiLove tab show up as "Show appreciation" for a while until the page finishes loading and the text is replaced by the heart icon. I think it'd be better to add the tab using JS and use the heart icon rightaway.
Strangely, I can't reproduce this locally. The heart icon is always loaded from the beginning along with the rest of the tabs even if I clear the cache. The behavior on office wiki is completely different and the icon display is significantly delayed.
In trunk a property 'position' exists for ResourceLoader modules. A few weeks ago the style module for WikiLove was given "position => top", which fixed the bug in trunk. On 1.17wmf1 however this property doesn't exist so it's loaded at the bottom still. There are other extensions currently live suffering the same problem (CodeReview and LiquidThreads). Marking as INVALID as the cause is in that Wikimedia is running two major releases ahead extensions on 1.17, impossible to fix and/or would cost valuable amount of wasted time - since there is no to loading in 1.17 currently. There are many work arounds possible, all with gotcha's. I suggest taking this for granted during the trial and make sure that we're in sync before real-wiki deployment.
(In reply to comment #2) > In trunk a property 'position' exists for ResourceLoader modules. A few weeks > ago the style module for WikiLove was given "position => top", which fixed the > bug in trunk. > > On 1.17wmf1 however this property doesn't exist so it's loaded at the bottom > still. D'oh! Given the fact that I implemented position=top, this is kind of embarrassing.
