Last modified: 2013-04-22 16:15:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31470, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29470 - Date suggestion should extract time as well from EXIF data
Date suggestion should extract time as well from EXIF data
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
http://commons.wikimedia.org/w/index....
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-18 08:05 UTC by Nemo
Modified: 2013-04-22 16:15 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nemo 2011-06-18 08:05:55 UTC
The prefilled date should include time, as most Commons tools and forms already do, instead of stripping it: it's a valuable piece of information and quite tedious to copy from exif data (especially if you don't know the #metadata section; and most users don't), as well as quite difficult to remember.
Comment 1 Nemo 2011-06-18 08:06:43 UTC
The problem was reported on http://commons.wikimedia.org/w/index.php?title=Commons:Bar_italiano&oldid=55623936#Scusate_se_fosse_una_banalit.C3.A0. when you can see that it produced quite a lot of confusion (as the length of the message shows).
Comment 2 Mark Holmquist 2012-05-15 00:58:45 UTC
Can someone attach an example file with EXIF time/date data to this bug report? I have been unable to find anything helpful in search engines.
Comment 3 Nemo 2012-05-15 23:28:26 UTC
(In reply to comment #2)
> Can someone attach an example file with EXIF time/date data to this bug report?
> I have been unable to find anything helpful in search engines.

Try https://commons.wikimedia.org/wiki/Special:Random/File
Comment 4 Mark Holmquist 2012-06-01 17:52:23 UTC
I have this patch 99% finished. The last bit of it is some i18n work, because there needs to be proper representation of the date and time. So, I'm asking the i18n people what to do, since there doesn't appear to be an obvious solution. Stay tuned.

Note that the date selector on that field will overwrite the value, and does not include time, so if you mess with it, you'll lose the time value. I suppose that won't matter for people who just want to get the time from the image and carry on, but it's a potential speed bump.
Comment 5 Mark Holmquist 2012-06-01 19:05:40 UTC
All right, going crazy today, here's a patch for you: https://gerrit.wikimedia.org/r/9654

It doesn't do anything complicated for the date output, so i18n might need to take a look at it and figure something out. If I need to write up a better way, so be it.
Comment 6 Nemo 2012-06-12 07:14:38 UTC
(In reply to comment #5)
> It doesn't do anything complicated for the date output, so i18n might need to
> take a look at it and figure something out. If I need to write up a better way,
> so be it.

What format are you using then? Commons wants 2012-06-12 9:14, although some string magic is applied to fix it anyway.
Comment 7 Thehelpfulone 2012-06-22 19:40:51 UTC
Reassigning to wikibugs-l per bug 37789
Comment 8 matanya 2012-08-14 12:25:35 UTC
removed i18n, as it isn't related to i18n. removed patch and patch need review as this patch is in gerrit.
Comment 9 Mark Holmquist 2012-08-14 16:01:16 UTC
matanya, the date format was why I was concerned, I didn't know if there was a better way to localise the date for display. This could be a useful addition to the mediawiki default modules....maybe in my mw.Time. All right, fair enough, this is clearly something I should look at :)

But until I get mw.Time merged and patched to do this, is there another way?

Also, I've been using patch and patch-need-review to indicate that it's separate from non-patched bugs. Without that tag, people might visit this bug looking for something to do, and only discover the patch after (best case) reading five comments or (worst case) fixing the bug themselves. Is this wrong? Should I do it a better way?
Comment 10 Nemo 2012-08-14 17:12:02 UTC
(In reply to comment #9)
> Should I do it a better way?

I don't know; I know that Sumana is doing it like you and that this is being discussed at https://www.mediawiki.org/wiki/Thread:Talk:Git/Workflow/Bugzilla 
Unless the decision has been taken elsewhere in the meanwhile, matanya should probably stop mass-adding/removing the keywords before there's some codified rule for them, and discussion should continue there.
Comment 11 Mark Holmquist 2012-08-14 17:15:27 UTC
Oh sorry, should have commented here.

Chad was kind enough to add the patch-in-gerrit keyword, so that I'm not making arbitrary and ambiguous (and potentially confusing) keyword choices.
Comment 12 Derk-Jan Hartman 2012-11-11 21:33:10 UTC
This change has been merged but I think it only displays the time in the datepicker now. it still inserts only the date into the field ?
Comment 13 Nemo 2012-11-11 22:06:36 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > It doesn't do anything complicated for the date output, so i18n might need to
> > take a look at it and figure something out. If I need to write up a better way,
> > so be it.
> 
> What format are you using then? Commons wants 2012-06-12 9:14, although some
> string magic is applied to fix it anyway.

https://commons.wikimedia.org/wiki/Template:Information/doc confirms it and https://commons.wikimedia.org/wiki/Template:ISOdate has the technical details for rendering.
Comment 14 Nischay Nahata 2013-02-09 17:59:35 UTC
Is this not fixed yet?

I also observed that for a file the time-date was collected by the exif data, but only the date can be entered using the datepicker not the time.
Comment 15 Nemo 2013-02-09 18:14:50 UTC
Yes, looks fixed now, and the format seems correct too.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links