Last modified: 2013-01-09 01:42:23 UTC
Created attachment 8676 [details] SQlite Support Patch This patch adds Sqlite support to Semantic Mediawiki.
:facepalm: SMW mostly doesn't use proper DB abstraction functions?
Thanks a lot for the patch, I'll merge it in soonish :) @Max: historical reasons, the db abstraction wasn't really up to it back then or something like that. The code should definitely be changed to make use of the db functions where possible, but this is a bunch of work, so any help on that would be appreciated :)
In that case, you need to forget about pre-1.16 compat ;)
Ah damn! The idea is to still support MW 1.15 for now. If this prevents using the generic database functions then that's another reason to discontinue support for it in one of the coming versions. Can you elaborate on what exactly is not supported in pre-1.16, or link to some docs that do?
buildLike()
Hofoen: I applied your patch, but the SMW setup script still fails for PostGres. To what extend did you get SMW to work with SQLite? Also, what is this _addition_ for? 'u' => ( ( $wgDBtype == 'postgres' || $wgDBtype == 'sqlite' ) ? 'TEXT' : 'VARCHAR(63) binary' ),
(In reply to comment #6) > Hofoen: I applied your patch, but the SMW setup script still fails for > PostGres. To what extend did you get SMW to work with SQLite? As far I can see, I tested everything except "concepts" with the Sqlite backend. Two issues are not solved: * COLUMN DROPs while schema migration, as this is not supported in Sqlite3 * some parts of SMW_SQLStore2::getUnusedPropertiesSpecial are left out for Sqlite > Also, what is this _addition_ for? > 'u' => ( ( $wgDBtype == 'postgres' || $wgDBtype == 'sqlite' ) ? 'TEXT' : > 'VARCHAR(63) binary' ), I accidently copied this line from SMW 1.5.3, which I had originally patched. It's not necessary any more in the trunk.
Right. I applied the patch to trunk and observed this: * Installation of SMW on SQLite MW did not work * SQL errors on installed SMW on a MySQL MW So I reverted it for now. Can you get the patch to work with trunk?
Any progress on this? Else I'm closing the bug.
hofoen, I'm marking your patch as reviewed per Jeroen's comments. Do you have time to revise it? Thanks.
Guess not :)
