Last modified: 2011-09-15 17:46:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31484, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29484 - Broken Compatibility
Broken Compatibility
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ImportFreeImages (Other open bugs)
unspecified
All All
: Unprioritized critical with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: upstream
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-19 01:44 UTC by DaSch
Modified: 2011-09-15 17:46 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description DaSch 2011-06-19 01:44:51 UTC
There are a lot of Strict Erros when using this Extensions

Strict Standards: is_a(): Deprecated. Please use the instanceof operator in /usr/share/psa-pear/HTTP/Request.php on line 692

Strict Standards: Non-static method PEAR::getStaticProperty() should not be called statically, assuming $this from incompatible context in /usr/share/psa-pear/HTTP/Request.php on line 724

Strict Standards: Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /usr/share/psa-pear/HTTP/Request.php on line 739

and so on… all the same

when trying to upload the name is not filled into the form and then it say's that the URL is missing.

So the Extenstion hardly does not work at all!

I'm using latest from SVN Mediawiki and the Extension
Comment 1 Bryan Tong Minh 2011-06-19 11:12:29 UTC
Those strict errors are PEAR's fault, not MediaWiki's, as can be clearly seen from the paths to the files.
Comment 2 Chad H. 2011-06-19 15:57:22 UTC
(In reply to comment #1)
> Those strict errors are PEAR's fault, not MediaWiki's, as can be clearly seen
> from the paths to the files.

Right, which is why I added +upstream :) Although at a quick glance, I couldn't figure where you were using PEAR modules in this extension.
Comment 3 Bryan Tong Minh 2011-06-19 16:05:21 UTC
Probably because that was what is was using when I rewrote it for 1.16.
Comment 4 Chad H. 2011-06-19 17:52:25 UTC
So I guess this is INVALID/FIXED by virtue of your rewrite.
Comment 5 DaSch 2011-06-19 20:19:58 UTC
Wait Wait
The point is, that the erros are displayed although error_reporting is set to 0 and the OpenID Extension is also using PEAR and gives no errors

And it's not just about the PEAR errors but that this extension is to correctly working with 1.19
Comment 6 Mark A. Hershberger 2011-06-21 22:28:41 UTC
(In reply to comment #5)
> The point is, that the erros are displayed although error_reporting is set to 0
> and the OpenID Extension is also using PEAR and gives no errors
> 
> And it's not just about the PEAR errors but that this extension is to correctly
> working with 1.19

It looks like error_reporting is being set in supressStrictWarnings() and restoreStrictWarnings() and the code is doing it wrongly.
Comment 7 DaSch 2011-08-30 14:55:33 UTC
Is anybody going to fix this great Extension?
There are a lot of errors because of the changes made in the upload section of mediawiki
Hope somebody can do this
Comment 8 Chad H. 2011-08-30 16:06:54 UTC
I don't see a bug here. As Bryan pointed out, the extension was fixed in trunk to not use PEAR anymore. The bug listed was relating to PEAR's HTTP Request package (which would be an upstream bug anyway).

OpenID doesn't use this package, so that's why it works.
Comment 9 DaSch 2011-08-30 16:35:25 UTC
so should I open a new bug for the issue
"when trying to upload the name is not filled into the form and then it say's
that the URL is missing."??

By the way the strict errors still apear in the last SVN Version
Comment 10 Mark A. Hershberger 2011-08-30 17:46:56 UTC
(In reply to comment #9)
> so should I open a new bug for the issue
> "when trying to upload the name is not filled into the form and then it say's
> that the URL is missing."??

Yes.

If you're still getting strict errors please past what you're getting into a comment here.
Comment 11 DaSch 2011-08-30 18:58:26 UTC
Strict Standards: is_a(): Deprecated. Please use the instanceof operator in /usr/share/psa-pear/HTTP/Request.php on line 692

Strict Standards: Non-static method PEAR::getStaticProperty() should not be called statically, assuming $this from incompatible context in /usr/share/psa-pear/HTTP/Request.php on line 724

Strict Standards: Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /usr/share/psa-pear/HTTP/Request.php on line 739

Strict Standards: is_a(): Deprecated. Please use the instanceof operator in /usr/share/php/PEAR.php on line 281

Strict Standards: Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /usr/share/psa-pear/HTTP/Request.php on line 741

Strict Standards: is_a(): Deprecated. Please use the instanceof operator in /usr/share/php/PEAR.php on line 281

Strict Standards: Non-static method PEAR::isError() should not be called statically, assuming $this from incompatible context in /usr/share/psa-pear/HTTP/Request.php on line 1284

it's too long. I hope the next ist only repeating
Comment 12 Chad H. 2011-08-30 19:31:06 UTC
As I said before, any errors in PEAR packages should be reported upstream.
Comment 13 DaSch 2011-08-30 19:48:07 UTC
I've the impression you focuse to much on the PEAR Errors.

The problem ist that they are displayed although displaying errors is disabled and when trying to import a picture there is this "when trying to upload the name is not filled into the form and then it say's
that the URL is missing." Error witch makes the Extension totalty useless
Comment 14 Chad H. 2011-08-30 19:51:21 UTC
(In reply to comment #13)
> I've the impression you focuse to much on the PEAR Errors.
> 

Those have been the only errors you've pasted.

> The problem ist that they are displayed although displaying errors is disabled
>

That's not a MediaWiki bug either.

> and when trying to import a picture there is this "when trying to upload the
> name is not filled into the form and then it say's
> that the URL is missing." Error witch makes the Extension totalty useless

*That* is perhaps an actual bug, but I'll let Bryan decide.
Comment 15 DaSch 2011-08-30 19:57:01 UTC
(In reply to comment #14)
> (In reply to comment #13)
> > I've the impression you focuse to much on the PEAR Errors.
> > 
> 
> Those have been the only errors you've pasted.
> 
> > The problem ist that they are displayed although displaying errors is disabled
> >
> 
> That's not a MediaWiki bug either.
That's a problem with the extension! I've disabled error reporting in LocalSettings and the ImportFreeImages Extension is the only place where errors are displayed
> 
> > and when trying to import a picture there is this "when trying to upload the
> > name is not filled into the form and then it say's
> > that the URL is missing." Error witch makes the Extension totalty useless
> 
> *That* is perhaps an actual bug, but I'll let Bryan decide.
Comment 16 Chad H. 2011-08-30 19:58:09 UTC
(In reply to comment #15)
> (In reply to comment #14)
> > (In reply to comment #13)
> > > I've the impression you focuse to much on the PEAR Errors.
> > > 
> > 
> > Those have been the only errors you've pasted.
> > 
> > > The problem ist that they are displayed although displaying errors is disabled
> > >
> > 
> > That's not a MediaWiki bug either.
> That's a problem with the extension! I've disabled error reporting in
> LocalSettings and the ImportFreeImages Extension is the only place where errors
> are displayed
> > 

That is not a bug in the extension, it sounds like PEAR is doing something wrong.
Comment 17 Platonides 2011-09-15 17:46:33 UTC
The extension is no longer using PEAR so closing as fixed.
Update your extension to the latest version.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links