Last modified: 2013-06-18 15:30:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31519, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29519 - Stomp pending processor will always run $batch_size times if there are one or more explicitly pending transactions
Stomp pending processor will always run $batch_size times if there are one or...
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Fundraising (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Arthur Richards
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-21 21:19 UTC by Katie Horn
Modified: 2013-06-18 15:30 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Katie Horn 2011-06-21 21:19:28 UTC
In stompPFPPendingProcessorSA.php: 

If the pending queue is shorter than $batch_size, and handle_pending_transaction() pushes one or more pending transactions back into the pending queue, those pending transactions just get back in the queue to be processed again in the same batch. Therefore, if one or more transactions come back from paypal with code 126 or 26, the processor can't quit before it's re-pulled and re-queued the pending items enough times to meet the initial $batch_size. 

The end result does not appear to be damaged by the current behavior; It's just an efficiency problem. Ideally, if the queue is shorter than the batch size when the processor gets kicked off, it would consume each transaction in the queue once, and exit.
Comment 1 Katie Horn 2012-06-12 22:45:30 UTC
I fixed this ages ago. Resolving.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links