Last modified: 2011-07-13 18:33:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31592, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29592 - WebChat iframe with based on screensize
WebChat iframe with based on screensize
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Robert Leverington
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-26 12:17 UTC by Raymond Martineau
Modified: 2011-07-13 18:33 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Example patch (629 bytes, text/plain)
2011-06-26 12:17 UTC, Raymond Martineau
Details

Description Raymond Martineau 2011-06-26 12:17:44 UTC
Created attachment 8708 [details]
Example patch

Extension:WebChat (http://www.mediawiki.org/wiki/Extension:WebChat) uses an iFrame to display content, that is automatically resized to screen width.  This forces the user to resize the browser to be unnecessarily wide. 

This is caused by /trunk/extensions/WebChat/WebChat_body.php, in function execute().

The attachment shows a sample change on how to fix the problem. It changes the iFrame width to 100%, letting the browser to resize the iFrame itself rather than hacking it through Javascript.

A sample fix is found on StrategyWiki, and may be copied from there.
Comment 1 Brion Vibber 2011-07-13 18:33:48 UTC
Patch seems to do the job! :) Looks ok in Firefox 5, IE 7, IE 6, didn't bother testing other browsers.

Applied in r92077 (with the commented lines removed).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links