Last modified: 2011-06-30 16:10:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31609, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29609 - The TT icon overlaps with the "select font" link when wgBetterDirectionality is enabled
The TT icon overlaps with the "select font" link when wgBetterDirectionality ...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WebFonts (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Santhosh Thottingal
: i18n
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-27 14:03 UTC by Amir E. Aharoni
Modified: 2011-06-30 16:10 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Amir E. Aharoni 2011-06-27 14:03:40 UTC
Robin's wgBetterDirectionality improvement was enabled in translatewiki.net recently. It greatly improves the handling of right-to-left languages there.

There's a problem with WebFonts, however: When the user's interface languages in the preferences is an RTL language, for example Hebrew, the TT (TrueType) icon near the font selection link in the top menu overlaps with the link text.

It is currently implemented as a CSS background-image property and the position is 0 60%, where 0 probably means "top left"; for RTL languages this is wrong. Maybe it can become a simple img tag before the link.
Comment 1 Santhosh Thottingal 2011-06-28 15:50:04 UTC
Fixed in r90972
Comment 2 Brion Vibber 2011-06-28 17:35:34 UTC
Reopening; there are other regressions with r90972 (see CR comments: z-index issue at least)
Comment 3 Robin Pepermans (SPQRobin) 2011-06-29 00:12:05 UTC
Indeed, the search box overlaps the font selection link. It should probably be right-aligned (next to the user name), as in LTR (i.e. RTL should mirror LTR).
Comment 4 Santhosh Thottingal 2011-06-30 15:31:40 UTC
z-index issue fixed in r91077

Added the page directionality condition in  r91179 . I am using $('body').hasClass('rtl') for finding the page direction.  ( '#p-personal ul' ).attr('dir')  does not give the value if wgBetterDirectionality is disabled. Using the rtl class of body is consistent. Is there a better way to do this?  Or is this fine?
Comment 5 Robin Pepermans (SPQRobin) 2011-06-30 16:10:06 UTC
It works correctly, as far as I can see.

(marked as resolved)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links