Last modified: 2014-03-02 14:47:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31621, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29621 - Can't create a username with multiple spaces in it (should fail better or something)
Can't create a username with multiple spaces in it (should fail better or som...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User login and signup (Other open bugs)
1.22.0
All All
: Normal normal (vote)
: 1.23.0 release
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-28 03:29 UTC by Bawolff (Brian Wolff)
Modified: 2014-03-02 14:47 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bawolff (Brian Wolff) 2011-06-28 03:29:32 UTC
Filing a bug mostly because I don't know what to do about it.

Tried to create an account named "tst  login" (note double space). This failed due to the check:

                $parsed = Title::newFromText( $name );
                if( is_null( $parsed )
                        || $parsed->getNamespace()
                        || strcmp( $name, $parsed->getPrefixedText() ) ) {

Which is meant to detect namespace prefixes. (the third part checks if its equal to its normalization, and fails if not)

We should probably just give a warning if the user name normalizes to something different then typed. We should also more generally be specific why things fail.
Comment 1 Andre Klapper 2013-04-17 12:34:28 UTC
Still valid, generic error message is "You have not specified a valid user name".
Comment 2 Bartosz Dziewoński 2014-02-20 00:18:59 UTC
(In reply to Bawolff (Brian Wolff) from comment #0)
> We should probably just give a warning if the user name normalizes to
> something different then typed. We should also more generally be specific
> why things fail.

This part is bug 61416.
Comment 3 Gerrit Notification Bot 2014-02-20 01:18:22 UTC
Change 114379 had a related patch set uploaded by Bartosz Dziewoński:
User: Be less stringent in getCanonicalName()

https://gerrit.wikimedia.org/r/114379
Comment 4 Gerrit Notification Bot 2014-02-25 01:49:47 UTC
Change 115329 had a related patch set uploaded by Bartosz Dziewoński:
SpecialUserlogin: Normalize username before passing to User::newFromName

https://gerrit.wikimedia.org/r/115329
Comment 5 Gerrit Notification Bot 2014-02-25 01:50:18 UTC
Change 114379 abandoned by Bartosz Dziewoński:
User: Be less stringent in getCanonicalName()

Reason:
Different, maybe less clean, but definitely less scary approach: https://gerrit.wikimedia.org/r/115329

https://gerrit.wikimedia.org/r/114379
Comment 6 Gerrit Notification Bot 2014-03-01 22:13:43 UTC
Change 115329 merged by jenkins-bot:
SpecialUserlogin: Normalize username before passing to User::newFromName

https://gerrit.wikimedia.org/r/115329

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links