Last modified: 2011-06-29 17:47:04 UTC
If you're writing a message in WikiLove and decide to switch from "Cookie" to "Cheeseburger", the form resets, clearing any user input such as a custom message text or custom header. If you notice this and try to switch back to "Cookie", the form simply resets again. The same behavior can be seen when switching from "Kittens" to "Make your own" (or whatever else) in the "Select type" section. When the user switches to a different type, any user input vanishes. This is upsetting. I'm not sure if this is browser specific. I'm running Chrome on OS X. If there's a way to make the data persist at least through one initiation of WikiLove, that would be great. I don't think storing "draft" messages (per user across an indefinite period of time) is necessary or anything like that. Switching between type or sub-type shouldn't trigger all the user input to disappear without warning, though.
Others have mentioned this as well. What we probably need to do is allow the messages to persist within WikiLove and only reset them if you close WikiLove and relaunch it.
Fixed in r90961, thanks for the bug report!
This works much better now. I'm re-opening for one minor quirk that remains in "make your own" mode. If you go to "make your own" and input a custom header or input a custom image and then switch to another type (such as "Kittens" or "Barnstars"), your input in the "make your own" selection for just those two fields still gets eaten. Message text and title persist through selection changes beautifully now, but losing a custom image input and custom header in "make your own" should be avoided, if possible. Thanks for responding to this so quickly! :-)
This isn't practically possible since those awards have preset titles and/or headers. Otherwise when you switch back to Make Your Own, you would see "The Original Barnstar" as the title. It's important to understand that the WikiLove extension is completely unaware of award types. These are just arbitrarily constructed in the config. Each award is simply a collection of 0-4 fields, preset values, and a template to plug the values into. Make Your Own isn't a special type. It's constructed in the same way as the other awards. It just happens to surface all the fields and not have any preset values. The idea is that the community could throw out all of our awards if they want to and create entirely new awards and award types for their particular wiki without having to ask any developers. The content of the tool is 100% configurable. Since Barnstars and Kittens have preset title and/or header fields, I don't think it makes sense for these to be persistent actually. Personally, I think only the message field should be persistent since it is never preset (although theoretically it could be). In addition, it is the most likely field to not be customized in some way by the user in relation to the specific award. If I set the title of my Make Your Own award to "A Giant Pink Unicorn", this isn't going to make sense if I switch it to Kitten or Cheeseburger and it still says "A Giant Pink Unicorn". Same for vice-versa.
Actually, it looks like Jan Paul has built a more complicated remembering system than what I was imagining (I was thinking we would just avoid resetting certain fields). It may be possible to implement something that is satisfactory to everyone with this system.
OK, all the fields get remembered now via Jan Paul's rememberInputData, as of r91051. The logic might need to be refined further at some point, but I guess this is a good solution for now.
