Last modified: 2014-06-14 18:36:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31629, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29629 - addModules(), etc. should warn when a passed array declares a module twice (overwriting)
addModules(), etc. should warn when a passed array declares a module twice (o...
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-28 16:59 UTC by Mark A. Hershberger
Modified: 2014-06-14 18:36 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mark A. Hershberger 2011-06-28 16:59:35 UTC
After watching Roan deal with this on IRC today (see r90960), there should be a way (in debug mode, or maybe when running E_STRICT) that a warning is displayed when addModuleStyles overwrites a previous style.
Comment 1 Roan Kattouw 2011-06-28 17:01:52 UTC
(In reply to comment #0)
> After watching Roan deal with this on IRC today (see r90960), there should be a
> way (in debug mode, or maybe when running E_STRICT) that a warning is displayed
> when addModuleStyles overwrites a previous style.
Impossible, marking WONTFIX.

The cause was something like:

$someglobal = array(
'foo' => stuff1,
'bar' => stuff2,
'foo' => stuff3,
);

Of course $someglobal['foo'] will end up being set to stuff3, and nothing will be able to detect that it was very temporarily set to stuff1 first.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links