Last modified: 2011-06-30 16:29:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31644, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 29644 - ExifBitmapHandler::formatMetadata() doesn't check before unserializing.
ExifBitmapHandler::formatMetadata() doesn't check before unserializing.
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.20.x
All All
: High normal (vote)
: ---
Assigned To: Bawolff (Brian Wolff)
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-06-29 14:00 UTC by Platonides
Modified: 2011-06-30 16:29 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Platonides 2011-06-29 14:00:53 UTC 
This can be reproduced with tests/phpunit/includes/media/FormatMetadataTest.php

ExifBitmap.php uses two variables BROKEN_FILE and OLD_BROKEN_FILE. If $metadata is ExifBitmapHandler::BROKEN_FILE isMetadataValid() considers it METADATA_GOOD. However, formatMetadata() would try to unserialize( "-1" ) which is an error.
Comment 1 Bryan Tong Minh 2011-06-30 16:29:40 UTC 
Fixed by bawolff in r91127.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links