Last modified: 2012-09-27 01:10:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31669, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29669 - Minor adjustments to Vector search button
Minor adjustments to Vector search button
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.17.x
All All
: Unprioritized normal (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-01 14:57 UTC by Erwin Dokter
Modified: 2012-09-27 01:10 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch for screen.css (513 bytes, patch)
2011-07-01 14:58 UTC, Erwin Dokter
Details

Description Erwin Dokter 2011-07-01 14:57:46 UTC
The search button in Vector has two minor CSS issues:

1. The looking glass image is too high in IE and Chrome, but looks OK in Firefox. Patch adjusts padding-top for button#searchButton from 0.2em to 0.3em, fixing the alignment in these browsers, with no visible difference in firefox (which adds 2px padding to buttons while other browsers don't).

2. The search button is styled extensively to remove any button properties, but allows background-image styles from generically-styled button elements to leak through. Patch adds {background-image: none;} to fix this.

(Note: I don't know if this impacts bug 25215 / r73427; I cannot see the CSS from that file being served anywhere, which means that it probably is not live yet? In that case, this patch may be a better resolution.)
Comment 1 Erwin Dokter 2011-07-01 14:58:08 UTC
Created attachment 8728 [details]
Patch for screen.css
Comment 2 Mark A. Hershberger 2011-07-02 16:12:57 UTC
r91356

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links