Last modified: 2011-07-05 01:27:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31712, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29712 - Default user options in MessagesXx files have no effect
Default user options in MessagesXx files have no effect
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User preferences (Other open bugs)
1.20.x
All All
: Unprioritized major (vote)
: ---
Assigned To: Nobody - You can work on this!
: i18n
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-04 22:26 UTC by Robin Pepermans (SPQRobin)
Modified: 2011-07-05 01:27 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Robin Pepermans (SPQRobin) 2011-07-04 22:26:28 UTC
The settings in the default user options in MessagesXx.php files (where xx is the wiki content language), have no effect. The value is overridden by the values in DefaultSettings.php. When removing an option from DefaultSettings, it uses the value again from MessagesXx.php

This bug is present for quite some time, since the defaultUserOptionOverrides are almost only used for quickbar (used by some legacy skins) by RTL languages, which is a small userbase so it didn't get noticed.

(Interesting side-note: in the case of quickbar for RTL languages, this bug is being "corrected" by another bug: CSS for RTL languages is flipped, so where "left" is the default option, it's flipped to "right", so your preferences will say you have left, while it's right, which it should be, but because of MessagesXx options and not because the CSS it's flipped)
Comment 1 Robin Pepermans (SPQRobin) 2011-07-04 23:43:49 UTC
I am going to remove this (broken) feature, because depending on wgLang for defaultUserOptionOverrides makes much more sense than wgContLang (as it currently is), but is not possible because wgLang depends on the preferences itself.

Secondly, the only three prefs set in MessagesXx files are:
* 'underline' => 0 by languages written in scripts that are hard to read with underlines -> can be set in CSS
* 'quickbar' => 2 by RTL languages, this can be done differently (in  SkinLegacy->qbSetting(à for example)
* 'editfont' => 'sans-serif' -> can be set in CSS
Comment 2 Robin Pepermans (SPQRobin) 2011-07-05 01:27:53 UTC
Done in r91432

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links