Last modified: 2012-11-01 22:54:47 UTC
By default: * Links are underlined only on hover for vector, monobook, etc * Links are always underlined for legacy skins like cologneblue, standard The underline option of Special:Preferences only works for the legacy skins (default is browser standard which is afaik nearly always "underlined"). Solutions: * If this is the intended behaviour, it should be mentioned on Special:Preferences that it only works for those skins * The option can be extended to work on all skins * The option can be removed as it is trivial and can be done by simple CSS (In general, more clean-up is needed for preferences & skins.)
(In reply to comment #0) > * The option can be removed as it is trivial and can be done by simple CSS > +1. Such an option would never have made it in these days, we would've told the person suggesting it to use site or user CSS to get such an effect.
I'm quite sure this works on trunk. Perhaps we forgot to backport a fix ?
The thing is that the default option "browser default" behaves differently per skin: legacy skins really use the browser default (always underline), while vector etc have CSS that override this: a { text-decoration: none; } a:hover { text-decoration: underline; } The other two options (never or always) do work correctly for all skins, afaik. Still, it may be a good idea to just remove this option. It was likely introduced for RTL languages which is no longer needed (see bug 29712).
I don't see the problem ... Why don't we just rename the option "browser default" to "skin default"...
This option is being removed with https://gerrit.wikimedia.org/r/#/c/27201/.
Gerrit change was abandoned - see discussion there as to why.
Not reproducible (anymore). Closing as WFM.
Hmm? Not reproducible? Afaik nothing changed since I submitted the bug, but I see you submitted https://gerrit.wikimedia.org/r/#/c/31268/ - which is good, I should've done it earlier. Reopening until that change is merged.
Merged the change myself now :)
Sorry, I interpreted "only works for legacy skins" as "changing the setting doesn't actually work in other skins".
(In reply to comment #10) > Sorry, I interpreted "only works for legacy skins" as "changing the setting > doesn't actually work in other skins". Just to clear things up... My initial bug report was based on what the description says: browser default => always underline => I saw it wasn't underlined in vector etc => I concluded it didn't work there... But now we changed the description to say what it actually does (browser AND SKIN dependent), so all is fine :)
