Last modified: 2014-09-23 22:59:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31720, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29720 - Wrong output of duplicate stylesheet links for site module
Wrong output of duplicate stylesheet links for site module
Status: NEW
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.17.x
All All
: Normal minor (vote)
: ---
Assigned To: Trevor Parscal
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-05 17:41 UTC by pioneeroverc
Modified: 2014-09-23 22:59 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
fix (677 bytes, patch)
2011-07-05 17:41 UTC, pioneeroverc
Details

Description pioneeroverc 2011-07-05 17:41:43 UTC
Created attachment 8741 [details]
fix

For some reason, on my wiki there were four, exactly identical CSS declarations like <link rel="stylesheet" href="/load.php?debug=false&amp;lang=it&amp;modules=site&amp;only=styles&amp;skin=vector&amp;*" />.  The cause of this, I was told on #mediawiki, is probably that I'm using root URLs (example.com/Page).  However, I was able to fix this issue by adding an array_unique function (see attached patch).
Comment 1 Brion Vibber 2011-07-05 20:28:59 UTC
That patch looks a bit off -- it just collapses an array of four empty arrays into an array of one empty array when it's initialized, right?

What's the actual problem causing this?
Comment 2 Krinkle 2011-07-07 19:57:12 UTC
The person on #mediawiki was me. I didn't mean to give the impression that the cause of this was using rewrite urls from root. You also mentioned a different issue (404 error on a .png image from /skins/foobar which MediaWiki interpreted as an article "Skins/foobar".)

The root URL is unlikely to be related to the duplicate embedding of stylesheets.
Comment 3 Roan Kattouw 2011-07-13 02:55:40 UTC
If the patch said something like array_map( 'array_unique', .... ) , I'd see why you might be doing that. But still it'd be nice to know where these duplicates come from.
Comment 4 Sumana Harihareswara 2011-11-08 13:17:26 UTC
pioneeroverc@yahoo.it, Thanks for your patch and for contributing to MediaWiki.

I am adding the "reviewed" keyword because there are comments here (from Roan, Krinkle, and Brion) on your patch.  Do you have the time and interest to respond, clarify the issue you're fixing, and write a new patch?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links