Last modified: 2011-09-06 11:50:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31724, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 29724 - The header with "User" "Flag" and "Date" shouldn't be displayed if the table is empty


Summary:	The header with "User" "Flag" and "Date" shouldn't be displayed if the table ...

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	CodeReview (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Low normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-07-05 22:31 UTC by Helder
Modified:	2011-09-06 11:50 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Helder 2011-07-05 22:31:03 UTC

Analogously to Bug 29297, I think the headers are unecessary if there are no rows in the table displayed below the "Sign-offs" header.

See e.g.:
http://www.mediawiki.org/wiki/Special:Code/MediaWiki/555#code-comments

Comment 1 Sam Reed (reedy) 2011-07-05 23:05:55 UTC

I'm pretty sure this is a dupe and has already been fixed in trunk

Comment 2 Helder 2011-07-05 23:10:11 UTC

Maybe you are thinking about Bug 29297, which reminded me about this one?

Comment 3 Sam Reed (reedy) 2011-07-05 23:13:41 UTC

		# Show sign-offs
		$userCanSignoff = $this->canSignoff();
		$signOffs = $this->mRev->getSignoffs();
		if ( count( $signOffs ) || $userCanSignoff ) {
			$html .= "<h2 id='code-signoffs'>" . wfMsgHtml( 'code-signoffs' ) .
				"</h2>\n" . $this->formatSignoffs( $signOffs, $userCanSignoff );
		}

The middle case here I think, is when the user is able to signoff, but there isn't any signoffs...

Comment 4 Sam Reed (reedy) 2011-09-06 11:50:51 UTC

r96322

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links