Last modified: 2014-06-17 17:03:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31749, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29749 - ext.vector.collapsibleNav.js shouldn't excludes IE6
ext.vector.collapsibleNav.js shouldn't excludes IE6
Status: RESOLVED FIXED
Product: MediaWiki skins
Classification: Unclassified
Vector (Other open bugs)
unspecified
All All
: Normal enhancement
: ---
Assigned To: Trevor Parscal
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-07 00:11 UTC by gdonato
Modified: 2014-06-17 17:03 UTC (History)
7 users (show)

See Also:
Web browser: Internet Explorer
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch for ext.vector.collapsibleNav.js (618 bytes, patch)
2011-07-07 00:39 UTC, Erwin Dokter
Details

Description gdonato 2011-07-07 00:11:05 UTC
In r67742, a check was added to exclude IE6 from collapsiblenav but informal testing shows collapsiblenav to work with IE6 without error. Since the restriction was added without comment it could be removed based on this.
Comment 1 Erwin Dokter 2011-07-07 00:39:11 UTC
Created attachment 8755 [details]
Patch for ext.vector.collapsibleNav.js

Patch for removing IE check.
Comment 2 Derk-Jan Hartman 2011-07-07 17:29:47 UTC
I think it once really did not work. But we have had several jquery updates since the original implementation, so that might have fixed it since the original implementation was developed.
Comment 3 Erwin Dokter 2011-12-31 17:00:44 UTC
Bump... Since it was a jQuery bug, can we deploy this patch now?
Comment 4 Krinkle 2011-12-31 18:11:02 UTC
Applied in r107729. Thanks!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links