Last modified: 2013-09-04 11:49:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31761, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 29761 - Postgres-based searching breaks between 1.13.1 and 1.17.0


Summary:	Postgres-based searching breaks between 1.13.1 and 1.17.0

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Search (Other open bugs)
Version:	1.17.x
Hardware:	All All

Importance:	High normal (vote)
Target Milestone:	1.18.0 release
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-07-07 19:43 UTC by Andy Lester
Modified:	2013-09-04 11:49 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Andy Lester 2011-07-07 19:43:22 UTC

I upgraded MW from 1.13.1 to 1.17.0, and the search summaries on my intranet wiki broke, manifested by errors in the Apache log like this:

PHP Warning:  pg_fetch_result(): supplied argument is not a valid PostgreSQL result resource in /var/www/html/bogey/mediawiki-1.17.0/includes/search/SearchPostgres.php on line 156

Turns out that when diffing 1.13.1's includes/SearchPostgres.php with 1.17.0's include/search/SearchPostgres.php, we see that line 151 in the 1.17.0 version

    $res = $this->db->query($SQL);

was originally, in 1.13.1

    $res = $this->db->doQuery($SQL);

When I change this line back to the 1.13.1 version, calling doQuery() instead of query(), everything works once again.

Comment 1 Sam Reed (reedy) 2011-07-07 21:58:09 UTC

The change for this, seems to have been past 1.17 for 1.18, but not obviously backported

Change was in r81499

Will ping hexmode

Comment 2 Sam Reed (reedy) 2011-07-07 22:00:44 UTC

And maybe r78450

Comment 3 Mark A. Hershberger 2011-07-13 17:37:32 UTC

Fix will be in the next release.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links