Last modified: 2014-02-15 21:39:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31778, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 29778 - Seperate or remove HTML from difference logic in diff engines
Seperate or remove HTML from difference logic in diff engines
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-07-08 21:18 UTC by Krinkle
Modified: 2014-02-15 21:39 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Krinkle 2011-07-08 21:18:28 UTC 
Initially I thought there were some regressions between 1.17 (or 1.17wmf1) and trunk but it turns out nothing changed.

I was surprised the diff-engines control many parts of the HTML output, this makes styling them hard and ugly.

For example the engine WMF uses has <span class="diffchange" /> inside "addedlines" or "removedlines", wheares DairikiDiff/WikiDiff (default) uses <ins> and <del>.
Comment 1 Mark A. Hershberger 2011-07-18 15:56:46 UTC 
<ins>/<del> seems more semantical and are in html5.  W00!
Comment 2 Max Semenik 2014-02-15 21:39:23 UTC 
The logic is, at least now, clearly separated: there's DairikiDiff that generates a set of differences and there's DiffFormatter that turns them into HTML. And you can plug in a different formatter implementation. As of PHP/wikidiff2 difference, it has been fixed with I0d39e4a44881b13f5d2c473ca273d729cffd156c.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links