Last modified: 2012-04-19 21:22:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31779, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29779 - DairikiDiff/WikiDiff <ins> and <del> should undo browser default styling (strike/underline)
DairikiDiff/WikiDiff <ins> and <del> should undo browser default styling (str...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
1.17.x
All All
: Unprioritized normal (vote)
: 1.18.0 release
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-08 21:22 UTC by Krinkle
Modified: 2012-04-19 21:22 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of WikiDiff in 1.19-svn localhost (106.71 KB, image/png)
2011-07-08 21:23 UTC, Krinkle
Details
Screenshot of WMF diff (60.24 KB, image/png)
2011-07-08 21:24 UTC, Krinkle
Details

Description Krinkle 2011-07-08 21:22:49 UTC
I thought this was a regression, because I compared a Wikimedia wiki history page with one on my localhost but that was due to bug 29778.

Currently text becomes confusing or unreadable in diffs during the use of <ins> and <del> without fighting the browser defaults (strking and underlining). See attached screenshots to see what I mean.

We should add default styling to prevent that.
Comment 1 Krinkle 2011-07-08 21:23:20 UTC
Created attachment 8760 [details]
Screenshot of WikiDiff in 1.19-svn localhost
Comment 2 Krinkle 2011-07-08 21:24:45 UTC
Created attachment 8761 [details]
Screenshot of WMF diff
Comment 3 Krinkle 2011-07-08 21:32:58 UTC
Fixed in r91762.
Comment 4 Antoine "hashar" Musso (WMF) 2011-07-08 21:41:06 UTC
updated version to 1.19.
Comment 5 Krinkle 2011-07-08 21:43:02 UTC
Set' back to 1.17 as this bug was reproduced there as well. It should be backported to 1.18 and if possible to 1.17. It may be too trivial for 1.17.1, but the bug version is still 1.17

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links