Last modified: 2011-07-10 23:50:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31805, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29805 - WikiLove should redirect to user talk view instead of reloading if wgAction isn't "view"
WikiLove should redirect to user talk view instead of reloading if wgAction i...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikiLove (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-10 21:14 UTC by Krinkle
Modified: 2011-07-10 23:50 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2011-07-10 21:14:56 UTC
When using WikiLove from another page it redirects to the user-talk page.
When already on the user-talk it reloads since reload doesn't happen when only the hash tag changes.

This code is at [0].

The bug occurs when using WikiLove from the user-talk page, but not in the 'view' action. (most noticeably action=history, but action=delete and action=protect as well)


--
Krinkle

[0] location redirect code: http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/WikiLove/modules/ext.wikiLove/ext.wikiLove.core.js?revision=91478&view=markup#l661
Comment 1 Krinkle 2011-07-10 21:24:35 UTC
Note that the bug also occurs when the action is 'view' but we viewing an older version of a talk page.

Steps to reproduce:
* Go to a user talk page with WikiLove-enabled
* Use the WikiLove dialog to send WikiLove
* Notice how it reloads and you're still viewing the old version of the page
Comment 2 Krinkle 2011-07-10 23:50:32 UTC
Fixed in r91853.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links