Last modified: 2013-06-18 15:51:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31850, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29850 - RSS feed broken in Safari
RSS feed broken in Safari
Status: RESOLVED WORKSFORME
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All Mac OS X 10.6
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: analytics, ops, upstream
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-12 22:13 UTC by Nimish Gautam
Modified: 2013-06-18 15:51 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nimish Gautam 2011-07-12 22:13:29 UTC
When opening RSS/Atom feed in safari (eg http://meta.wikimedia.org/w/index.php?title=Special:RecentChanges&feed=atom), Safari displays an error
Comment 1 Dario Taraborelli 2011-07-12 22:24:34 UTC
A few more notes (I was the original reporter of this problem, thanks Nimish for double checking):

• Watchlist feeds work fine (but they are generated by calling api.php?action=feedwatchlist )
• Revision feeds also appear to be broken in Safari
• The issue appears to be broader than Safari. If you open the feed in FireFox and try to subscribe to it via Mail.app (the default feed reader on Mac OS), the feed is also broken
Comment 2 Dario Taraborelli 2011-07-12 22:26:48 UTC
FYI my setup is:

Mac 10.6.8
Safari 5.0.5
Mail 4.5
Comment 3 Brion Vibber 2011-07-13 00:28:07 UTC
Looks like Domas hacked something into our squid configurations to block it in February 2010, presumably due to some brain-dead automatic polling:


http://wikitech.wikimedia.org/view/Server_admin_log/Archive_15#February_16

03:16 domas: blocked MacOSX Atom syndication on the edge, this will save terabytes of diskspace on unsuspecting Safari user computers :-) 


Of course if this just stops you from being able to read the feed at all even on explicit view, that's a bit annoying. :) Not sure what the current state of this is, but I can confirm being unable to read the Recentchanges Atom & RSS feeds from Safari here.
Comment 4 JeLuF 2011-07-15 18:20:39 UTC
The bug is on Safari's side. It's downloading each and every RSS feed that it can find and also tries to update it. This is putting a high load on our servers and as well pollutes the disks of Wikipedia editors that are visiting many pages with RSS feeds.

There's nothing we can do from the "shell" side to solve this issue, so that I've removed the "shell" keyword.
Comment 5 Brion Vibber 2011-07-15 19:04:12 UTC
Is the exact behavior documented? I can't reproduce "downloading each and every RSS feed that it can find" with Safari 5.0.5; it doesn't seem to fetch autodiscovered feeds until I explicitly request them by clicking on the RSS icon.

There are options to 'fetch updates' automatically for RSS items in bookmarks bar or whole bookmarks menu, but it looks like this will only apply if you've bookmarked the feed, not if you've bookmarked a page that happens to have a feed on it. On the other hand it might. :)  Waiting 30 mins to see what happens...


On the block itself; it looks like when you hit a feed, Safari does two hits: first as itself (regular Safari UA string), then again as Apple-PubSub. If it's the second one we're blocking, then I guess Safari's only using the first download to confirm it's a feed and then passes the URL off to its feed reader submodule to fetch again and process, where it dies.

It'd be nice if we can make sure a sane error message makes it back, but not sure if that's feasible.
Comment 6 JeLuF 2011-07-15 19:19:56 UTC
To be honest, I just relayed the answer Domas gave me yesterday regarding his motivation to block Safari. I'm sorry that I can't provide you with any details.
Comment 7 Brion Vibber 2011-07-15 20:38:41 UTC
So far it looks like Safari will re-fetch the feed in the background if you bookmarked a feed directly, but does not appear to be fetching feeds if you just bookmark an article page (which has autodiscovery markers for the RecentChanges feed, and thus shows the 'rss' icon so you can get *to* the feed).

Since the raw RC feed is nigh-useless on big sites anyway we probably shouldn't actually be offering it as autodiscovery anyway, but it looks like it takes an explicit action (click) to get there, and another explicit action (bookmark) to get it to where it'll get reloaded.

Retooling the feeds so that the default feed URL is sanely squid-cachable would likely also help.
Comment 8 Brion Vibber 2011-07-15 20:42:18 UTC
Restoring 'shell' keyword -- if the reason for the block is no longer valid (maybe an old version of Safari was worse?) then it should be removed, and only shell users can do that.

If removing unnecessary and useless RC feed links on the biggest sites would help reduce the frequency of people having silly feeds, then disabling that is probably something that needs to be done from site configuration, which needs a shell user.

If making the feeds more squid-cachable would help, then that'll need some development (should open a new bug and mark it as blocking this).
Comment 9 Domas Mituzas 2011-07-16 08:11:42 UTC
The problem is that one you _open_ RSS feed, it gets syncidated forever in some local store, and whole RSS then bloats gigabytes of storage locally (and yes, there're useless calls to RSS layer).

As we can't differentiate between proper intended RSS request and unintended one, we are saving our users. 

It isn't link existence that causes the behavior, it is actually opening that link from Safari.
Comment 10 p858snake 2011-07-16 08:15:36 UTC
So that is a user issue... we shouldn't be blocking that.
Comment 11 Domas Mituzas 2011-07-16 08:18:43 UTC
who are you, and on what did you base your opinion? 
in the end, everything is a user issue, we shouldn't do anything.
Comment 12 Brion Vibber 2011-10-16 16:35:52 UTC
(In reply to comment #9)
> The problem is that one you _open_ RSS feed, it gets syncidated forever in some
> local store, and whole RSS then bloats gigabytes of storage locally (and yes,
> there're useless calls to RSS layer).
> 
> As we can't differentiate between proper intended RSS request and unintended
> one, we are saving our users. 
> 
> It isn't link existence that causes the behavior, it is actually opening that
> link from Safari.

As far as others have been able to determine from testing, this doesn't actually happen; only bookmarking the feed causes it to be loaded and stored in the future.

Can you provide steps to reproduce?
Comment 13 Domas Mituzas 2011-10-16 17:03:01 UTC
You can see all subscriptions using 'pubsub list' command, or checking them directly in PubSub database:

sqlite ~/Library/PubSub/Database/Database.sqlite3 

I don't see this behavior on newest Safari yet, but I see quite a few feeds I'd never add myself ;-)
Comment 14 Mark A. Hershberger 2011-10-16 17:17:27 UTC
ACLs should be re-enabled and then Tim will then gather some statistics on subscriptions.
Comment 15 Nemo 2012-08-23 22:12:06 UTC
(In reply to comment #14)
> ACLs should be re-enabled and then Tim will then gather some statistics on
> subscriptions.

Did this happen?
Is the Safari bug filed somewhere?
Comment 16 Andre Klapper 2012-11-02 12:17:15 UTC
Does the problem still happen in recent Safari versions? If yes, which version?

Tim: Do you know if ACLs got reenabled?
Comment 17 Andre Klapper 2012-11-26 12:21:47 UTC
Domas: Is this still a problem? If so, in which Safari version?
Comment 18 Domas Mituzas 2012-11-26 20:15:34 UTC
I don't know! Doesn't this bug say that these rules were removed back in 2011?!!?
Comment 19 Andre Klapper 2012-11-26 20:18:58 UTC
If the bug report says so, I've failed to find that comment. :(

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links