Last modified: 2011-07-14 15:29:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31884, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29884 - Gallery default filename caption unnecessarily removes filename extension
Gallery default filename caption unnecessarily removes filename extension
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
SemanticResultFormats (Other open bugs)
unspecified
All All
: Unprioritized minor (vote)
: ---
Assigned To: Jeroen De Dauw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-14 00:57 UTC by badon
Modified: 2011-07-14 15:29 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description badon 2011-07-14 00:57:16 UTC
On line 66 of SRF_Gallery.php the filename extensions are removed for no good reason. I assume this was done with the thinking that a properly named file would eliminate the need for a caption, so when the filename is used as the default caption, the file extension would seem out of place.

But...

Most of the time filenames are nonsensical AND they can't be renamed. So, without the file extension, it is confusing. There is no reason to do this work by default, and so this feature should be removed unless there's some good reason for the bug-fixer to choose to make it an OPTION (not the default).

I suspect that it may also be related to the cause of this bug, where turning off autocaptions does not work:

https://bugzilla.wikimedia.org/show_bug.cgi?id=29875

By the way, not having a complete file name could complicate other tasks that might try to use data from Semantic Results Format.
Comment 1 Jeroen De Dauw 2011-07-14 11:49:36 UTC
I will have a look at this as soon as I have some time :)

> By the way, not having a complete file name could complicate other tasks that
might try to use data from Semantic Results Format.

If you want to get data for usage in some other app, then you should not use the gallery format, but rather XML, JSON or similar.
Comment 2 Jeroen De Dauw 2011-07-14 15:29:10 UTC
I added a parameter to allow for the behavior you want in r92161.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links