Last modified: 2013-01-29 10:51:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32096, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 30096 - SRF - Exhibit queries no longer work with SMW 1.6
SRF - Exhibit queries no longer work with SMW 1.6
Status: RESOLVED WONTFIX
Product: MediaWiki extensions
Classification: Unclassified
SemanticResultFormats (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-28 12:34 UTC by Neill Mitchell
Modified: 2013-01-29 10:51 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Neill Mitchell 2011-07-28 12:34:32 UTC
Hi.

I've just updated to SMW 1.6RC1 to perform some regression testing. This meant I had to update SRF to version 1.6RC1 r93379.

Exhibit queries no longer work and it seems to be making external calls now to simile.org. Something major has obviously changed, but I cannot see any reference on the MW SRF page.

e.g.

{{#ask:
[[Category:Articles]]
[[Headline::+]]
|?Headline
|?Body Text
|?Day
|?Month
|?Year
|facets=Year,Month
|format=exhibit
}}

now returns nothing.

This will break all the SMW websites I have deployed as I use exhibit a lot.

Thanks.
Comment 1 Jeroen De Dauw 2011-07-28 12:58:38 UTC
> it seems to be making external calls now to simile.org.

I hope you mean that svn is pulling from that site, and not that resources are getting loaded from there when actually using Exhibit? I recently replaced the copy of Exhbit in SRF with an svn externals to trunk of the exhibit repo.

I also attempted to fix Exhibit compat with MW 1.17, but apparently broke things. I will revert these changes soonish, as I don't have time to debug and fix this.
Comment 2 Neill Mitchell 2011-07-28 13:08:32 UTC
Hi Jeroen.

No, when an exhibit query now runs you can see it making calls out to simile.org.
Perhaps svn is pulling the new Exhibit V3?

I guess the simple short term resolution is to make SRF 1.4.3 compatible with SMW 1.6. It throws an error at present, but I would think it would be easier to fix this than try to sort out exhibit itself. This way a compatibility path will be maintained.

Cheers
Neill.
Comment 3 Neill Mitchell 2011-07-28 13:12:18 UTC
FYI. SRF 1.5.3 error when running with SMW 1.6 is:
PHP Fatal error:  Declaration of SRFExhibit::getResultText() must be compatible with that of SMWResultPrinter::getResultText() in /var/www/webapps/iow/extensions/SemanticResultFormats/Exhibit/SRF_Exhibit.php on line 452

Sorry in comment 2 above 1.4.3 should read 1.5.3 :)

Cheers
Neill.
Comment 4 Jeroen De Dauw 2011-07-28 13:15:47 UTC
Modifying SRF 1.5.x to work with SMW 1.6.x or above is not practical. The easiest way to fix this is just revert the changes I made a few days ago.

> No, when an exhibit query now runs you can see it making calls out to
simile.org.

That's not very nice...

> Perhaps svn is pulling the new Exhibit V3?

It's pulling Exhibit trunk. I was hoping this would get rid of previously reported JS issues, but if this causes problems, I'll also just revert. I really don't have time ATM to do anything more.
Comment 5 Neill Mitchell 2011-07-28 13:23:42 UTC
Hi Jeroen.

I understand the time pressures you are no doubt under. The revert should hopefully sort it for now.

I guess it will have to be got working somehow before SMW 1.6 goes live though or a lot of people will have broken sites. It is one of the most useful query formats. It's a shame it is such a nasty tangle of javascript!

I would suggest that version of the exhibit js used by SRF 1.5.3 be used. The exhibit trunk is indeed V3 which is a radical departure from V2 and is only in early alpha stage. I doubt it will even produce any output with SRF.

One day soon we'll kick off that re-write we spoke about a while back :)

Cheers
Neill.
Comment 6 Jeroen De Dauw 2011-07-28 14:53:20 UTC
Thanks for figuring out the Exhibit version difference; I actually concluded it was pretty much the same when I put in the svn externals, but apparently not.

> It is one of the most useful query formats.

To bad no one is maintaining it though; if some dev would step up to do that, it'd be awesome.

> One day soon we'll kick off that re-write we spoke about a while back :)

Right; do give me a heads up in advance if possible, so I can make time for it.
Comment 7 Neill Mitchell 2011-07-28 15:07:49 UTC
> To bad no one is maintaining it though; if some dev would step up to do that,
it'd be awesome.

Well, they seem to be writing version 3 :) I wonder if they will sort out the mess or just add to it ;)
Comment 8 Jeroen De Dauw 2011-07-29 16:07:54 UTC
I moved the trunk version of the format out of the way in r93461 and put in an older version of the format in r93462. Can you confirm it works now as it did before? I'd like to release SRF 1.6 this weekend :)
Comment 9 Neill Mitchell 2011-07-29 16:38:30 UTC
Hi Jeroen.

The actual SRF_Exhibit.php file seems to be missing?

Cheers
Neill.
Comment 10 Jeroen De Dauw 2011-07-29 17:03:22 UTC
Oh wtf, something went wrong w/ copying the files... Will fix now
Comment 11 Jeroen De Dauw 2011-07-29 17:07:38 UTC
I guess I ran svn add before my copy was done. Should be fixed by r93470
Comment 12 Neill Mitchell 2011-07-29 19:28:26 UTC
Okay, got revision 93470.

Exhibit queries still don't return anything :(
Comment 13 Neill Mitchell 2011-07-29 19:30:39 UTC
Fired up Firebug. Seeing the following error:

wgServer is not defined
http://localhost/iow/extensions/SemanticResultFormats/Exhibit/exhibit/exhibit-api.js?autoCreate=false&safe=true&bundle=false
Line 254
Comment 14 Jeroen De Dauw 2011-07-29 19:33:55 UTC
That issue is not related to the changes I made. Looks like a MediaWiki compat issue. Exhibit won't work with MW 1.17 or above, so if you are running that version, forget about getting it to work. My changes attempted to fix the incompat, but need more work.
Comment 15 Yaron Koren 2011-07-29 19:41:03 UTC
Yeah, the $wgServer global was removed in MW 1.17. That one's easy to fix, but I bet there are a bunch of other compatibility problems that need to be addressed for MW 1.17, due to the ResourceLoader...
Comment 16 Neill Mitchell 2011-08-01 08:58:24 UTC
Hi Jeroen.

But isn't it the SRF exhibit wrapper that needs changing? The actual exhibit js is stand alone and is not the bit that is broken no?

Cheers
Neill
Comment 17 Jeroen De Dauw 2011-08-01 14:32:20 UTC
Exhbit itself might not be broken, but the wrapper definitely is. For one thing, the loading of the library is not done in such a way that it'll work with MW 1.17 and later. 

Need to find someone who wants to maintain this format, and the timeline/eventline one for that matter...
Comment 18 Neill Mitchell 2011-08-01 15:05:07 UTC
Hi Jeroen.

Originally the one of the most exciting features of SRF was the Simile query formats. So not having them now is bad news as they are out there and being actively used by existing projects and sites. These will all now be stuck at SMW 1.5.6 and SRF 1.5.3 and not be able to leverage the new functionality.

I think you'll have a lot of very upset people if these formats are effectively dropped!

Cheers
Neill.
Comment 19 Jeroen De Dauw 2011-08-01 15:40:03 UTC
Sure. That doesn't change the fact that I simply cannot maintain them on top of all the other stuff I'm already maintaining, hence my note that a maintainer needs to be found.
Comment 20 Neill Mitchell 2011-08-01 16:12:04 UTC
I completely understand, but it seems kinda pointless releasing a new version of SRF with half the query types broken. The MW extension page needs to at least say that timeline, eventline and exhibit are not working with version 1.6 to avoid a lot of posts and questions. 

Perhaps drop a note on the mailing list to see if we can find someone to patch up the wrappers? 

Cheers
Neill.
Comment 21 Jeroen De Dauw 2011-08-01 16:21:27 UTC
Timeline and eventline are working. Also, this release contains many fixes and new features the old one does not have. And compatibility with SMW 1.6... Doesn't seem pointless to me.
Comment 22 Neill Mitchell 2011-08-01 16:46:38 UTC
Oh, timelines and event lines weren't working for me on Friday. I'll try again :)
Comment 23 Jeroen De Dauw 2011-08-01 17:01:47 UTC
Seems to work fine http://mapping.referata.com/wiki/User:Jeroen_De_Dauw/timeline_test

Also works fine on trunk for me.
Comment 24 Jeroen De Dauw 2011-10-31 01:12:14 UTC
This should have been fixed. If this is not the case, and it's still broken on trunk, please re-open or create a new bug report.
Comment 25 Neill Mitchell 2011-10-31 12:40:09 UTC
Great. Thanks for that. I will test it Jeroen.

:)
Comment 26 Neill Mitchell 2011-11-21 16:33:05 UTC
Just tried r103819 and it still doesn't work. Same as before - nothing gets returned :(
Comment 27 Neill Mitchell 2011-11-22 09:27:20 UTC
OKay, in Firebug I see the following errors thrown:

wgBreakFrames is not defined
[Break On This Error] if ( wgBreakFrames ) {
wikibits.js?301 (line 124)

wgServer is not defined
http://localhost/iow/extensions/SemanticResultFormats/Exhibit/exhibit/exhibit-api.js?autoCreate=false&safe=true&bundle=false
Line 254

onloadFuncts is undefined
http://localhost/iow/load.php?debug=false&lang=en&modules=ext.qpoll%7Cjquery.checkboxShiftClick%2Cclient%2Ccookie%2Cplaceholder%7Cmediawiki.language%2Cutil%7Cmediawiki.legacy.ajax%2Cajaxwatch%2Cmwsuggest%2Cwikibits&skin=around&version=NaNNaNNaNTNaNNaNNaNZ
Line 59
Comment 28 Jeroen De Dauw 2011-11-23 13:37:41 UTC
That's incompatibility with MediwWiki 1.17 and later... Should be not to hard to load the compatibility modules, if they still exist on trunk that is :)

Will have a look at this soonish.
Comment 29 Jeroen De Dauw 2011-11-23 14:35:32 UTC
r104038 might have fixed it.
Comment 30 Neill Mitchell 2011-11-23 15:26:18 UTC
Hi. Just tried it. Still not working I'm afraid. Errors are:

"NetworkError: 404 Not Found - http://localhost/iow/common/wikibits.js"
wikibits.js
wgBreakFrames is not defined
[Break On This Error] if ( wgBreakFrames ) {
wikibits.js?301 (line 124)

"NetworkError: 404 Not Found - http://localhost/iow/common/wikibits.js"
wikibits.js

wgServer is not defined
[Break On This Error] wgServer + wgScriptPath + ...ax/simile-ajax-api.js?bundle=false" :
exhibi...e=false (line 254)

onloadFuncts is undefined
error source line: [Break On This Error] message);}else{messageDiv.innerHTML=me...r);}}function addClickHandler(element 

Cheers
Neill.
Comment 31 Jeroen De Dauw 2011-11-23 15:30:13 UTC
Ok - then it does not work with 1.17. Need to find someone who wants to maintain the Exhibit format...
Comment 32 Neill Mitchell 2011-11-23 15:46:13 UTC
HI.

This all looks MW side? Do you know why is the interface so different to the other Simile formats that work?

Cheers
Neill.
Comment 33 Neill Mitchell 2013-01-29 10:51:10 UTC
Superseded by the new Filtered format.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links