Last modified: 2011-07-31 12:16:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32139, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 30139 - JS error on SpecialBannerController


Summary:	JS error on SpecialBannerController

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	CentralNotice (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-07-30 22:49 UTC by Sam Reed (reedy)
Modified:	2011-07-31 12:16 UTC (History)
CC List:	1 user (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2011-07-30 22:49:44 UTC

Uncaught TypeError: Cannot read property 'length' of null

        var url = 'http://wikimediafoundation.org/wiki/Special:LandingCheck';       if ( bannerJson.landingPages.length ) {

Line 169 of CentralNotice\special\SpecialBannerController.php


Seen on enwiki and dewiki frontpages

Comment 1 Sam Reed (reedy) 2011-07-30 22:54:28 UTC

Seems to occur logged in and logged out

Comment 2 Ryan Kaldari 2011-07-31 02:48:37 UTC

Someone must be recycling a very old banner.

I need to know what browser you're using in order to test. Firefox doesn't seem to have a problem with getting the length of null, so I can't reproduce locally.

Comment 3 Ryan Kaldari 2011-07-31 02:56:56 UTC

Looks like it must be Chrome. Should be fixed in r93566.

Comment 4 Sam Reed (reedy) 2011-07-31 12:16:08 UTC

(In reply to comment #3)
> Looks like it must be Chrome. Should be fixed in r93566.

Yeah, it was Chrome, sorry forgot to say that.

Thanks!

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links