Last modified: 2013-02-26 01:24:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32154, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 30154 - Uncaught TypeError: Cannot read property 'query' of null
Uncaught TypeError: Cannot read property 'query' of null
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
LiquidThreads (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: javascript
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-31 17:36 UTC by Helder
Modified: 2013-02-26 01:24 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Helder 2011-07-31 17:36:43 UTC
This bug doesn't seems to happen often, but I've noticed the following error after trying to submit a new reply to a thread:

Uncaught TypeError: Cannot read property 'query' of null

I was using Google Chromium 12.0.742.112 (90304) Ubuntu 11.04.
Comment 1 sheac 2012-05-13 19:45:04 UTC
This bug has not been touched in at least six months. With this in mind, I've been asked by the bugmeister to bump this bug's priority down from "High". Concerns can be addressed to mah@everybody.org.
Comment 2 Alex Monk 2013-02-25 02:40:20 UTC
Can you still reproduce this bug? If so, can you find the line it occurs on?
Comment 3 Helder 2013-02-25 12:00:05 UTC
Not really. But since there are only 5 occurrences of ".query" at
http://pt.wikibooks.org/w/extensions/LiquidThreads/lqt.js
and all of them occur in a code of the form
-----------------------------------------
$j.get( mw.util.wikiScript( 'api' ), ...,
	function(data) {
		...
		data.query.threads
		...
	}, 'json' );
-----------------------------------------
I think this would probably not happen if the 'mediawiki.api' module was used to handle the API requests. Indeed, that module has checks for 'data' being undefined and API errors:
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=resources/mediawiki.api/mediawiki.api.js;h=cf7443f3b3bfa35e6c52a7043e76a2f17c52adf8;hb=HEAD#l160

This would probably help with bug 28132 as well.
Comment 4 Alex Monk 2013-02-26 01:24:02 UTC
(In reply to comment #3)
> I think this would probably not happen if the 'mediawiki.api' module was used
> to handle the API requests. Indeed, that module has checks for 'data' being
> undefined and API errors:
> https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;
> f=resources/mediawiki.api/mediawiki.api.js;
> h=cf7443f3b3bfa35e6c52a7043e76a2f17c52adf8;hb=HEAD#l160
> 
> This would probably help with bug 28132 as well.

Doing this as part of Gerrit change #50857

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links