Last modified: 2011-08-04 22:03:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32198, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 30198 - Copyright icon element should not be outputted if $wgCopyrightIcon is disabled
Copyright icon element should not be outputted if $wgCopyrightIcon is disabled
Status: RESOLVED WORKSFORME
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.17.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-03 14:30 UTC by Dan Barrett
Modified: 2011-08-04 22:03 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dan Barrett 2011-08-03 14:30:27 UTC
In monobook skin, the following div gets produced at the bottom of each page if the site has no copyright icon assigned:

	<div id="f-copyrightico">
		<img src="" alt="1" width="88" height="31" />
	</div>

Because the img "src" value is the empty string, this causes a redundant HTTP GET request to the current page. This tries to load the current page as an image resource, which seems to impact performance, particularly on the edit page in IE8 (where we see a pause due to trying to load this image).

Correct behavior: if there is no icon image, this div should not be rendered at all.

This might be related to bug 26921: I don't know.

Shared credit goes to Jimbo Wilson for finding this bug.
Comment 1 Krinkle 2011-08-04 12:46:36 UTC
This bug is not related to bug 26921. The prototype server was misconfigured and/or has a missing file that someone forgot to upload, not a bug with the MediaWiki software itself.

The copyright icon should not be shown unless it's used, afaik this is currently the case. Can you link to an example of where this bug (empty img tag) is happening ? Or if it's not public, show steps to reproduce it on a trunk checkout.
Comment 2 Dan Barrett 2011-08-04 14:33:55 UTC
I believe you can reproduce this simply by installing MediaWiki 1.17.0 and changing the default skin to Monobook.
Comment 3 Dan Collins 2011-08-04 22:03:07 UTC
Cannot reproduce. Installed r93611 and set $wgFooterIcons['copyright']['copyright'] = NULL, visited Main_Page?useskin=monobook and there is an empty div, no img tag in it. Note that $wgCopyrightIcon is deprecated. Closing WORKSFORME.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links