Last modified: 2011-08-14 20:53:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32259, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 30259 - [Regression] ajax.watch throws JavaScript error in Vector skin
[Regression] ajax.watch throws JavaScript error in Vector skin
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.20.x
All All
: Unprioritized normal (vote)
: ---
Assigned To: Brion Vibber
: code-update-regression
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-08-06 08:05 UTC by Michael M.
Modified: 2011-08-14 20:53 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Michael M. 2011-08-06 08:05:32 UTC 
Steps to reproduce:

1. Open any page in for editing in Vector skin.
2. Click the star to watch the page.

Expected result:
The page should be added to watchlist, the star should be updated.

Actual result:
The page is added to watchlist, but then a Javascript error occurs:
 $link.attr("title") is undefined
The rotating star icon remains.
Comment 1 Brion Vibber 2011-08-06 11:25:36 UTC 
I can confirm on trunk (not in 1.17wmf1 production) on Firefox 5.0.1. Taking a quick peek.
Comment 2 Brion Vibber 2011-08-06 12:01:02 UTC 
This appears to be triggered directly by the jQuery 1.6.1 update (changing the return value from the .attr) but is *actually* caused by a serious regression in tooltip generation from r89123.


When the 'tooltiponly' attribute gets set to disable the access key on the watch tab (from r79383) the watch/unwatch link ends up like this:

<a href="/trunk/index.php?title=Main_Page&amp;action=unwatch&amp;token=..." Remove this page from your watchlist>

The title is being dropped directly into the <a> instead of in a title attribute, because a correct Linker::tooltip() call was replaced with an incorrect Linker::titleAttrib() call.
Comment 3 Brion Vibber 2011-08-06 12:07:36 UTC 
Reverted in r94024 on trunk and r94025 on REL1_18.
Comment 4 Krinkle 2011-08-14 20:53:10 UTC 
*** Bug 30372 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links