Last modified: 2013-09-04 11:49:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32264, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 30264 - MediaWiki installer should use require_once() instead of require() for extensions
MediaWiki installer should use require_once() instead of require() for extens...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
1.17.x
All All
: Normal trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-08-06 20:07 UTC by Dan Collins
Modified: 2013-09-04 11:49 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Dan Collins 2011-08-06 20:07:50 UTC 
All extension documentation says to use require_once to add an extension to LocalSettings.php, however the installer uses require when it automatically detects that an extension is available. For consistency, this should be changed to require_once. 

One good reason to do this is to avoid users copying the require statement used by the installer for other extensions, which could cause the inadvertent double-inclusion that the use of require_once avoids.
Comment 1 Chad H. 2011-08-09 13:59:52 UTC 
Fixed in r94107.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links