Last modified: 2011-08-29 21:07:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32271, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 30271 - Special:BannerAllocation should use GET instead of POST
Special:BannerAllocation should use GET instead of POST
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CentralNotice (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Jeremy Postlethwaite
http://meta.wikimedia.org/wiki/Specia...
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-08 01:06 UTC by MZMcBride
Modified: 2011-08-29 21:07 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MZMcBride 2011-08-08 01:06:45 UTC
http://meta.wikimedia.org/wiki/Special:BannerAllocation currently uses <form action="post">. This makes sharing links to a particular view impossible. How are my friends going to gossip about banner allocation without a direct link?

Probably makes sense to switch this to GET. I don't know why it was originally implemented with POST, but I don't see any drawbacks to a switch.
Comment 1 MZMcBride 2011-08-08 01:12:56 UTC
I looked at <http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/CentralNotice/special/SpecialBannerAllocation.php?revision=92809&view=markup> and some older revisions of the file. I don't see any reason it ever used post, other than that's how it was originally written. Parameter names look sane enough. Not sure how stable their values are, but they'll need to be reasonably stable in order to support URLs into the future.

One thing I notice is that it's setting a default to en/wikipedia/US. Might make sense to switch that to all, if/when the option is added. I don't think making these changes would be very difficult. This bug has been marked as easy, accordingly.
Comment 2 Umherirrender 2011-08-08 16:59:14 UTC
A other special page in that extension also used POST in the past, see bug 30057
Comment 3 Jeremy Postlethwaite 2011-08-29 21:07:48 UTC
Fixed in r95697: Switched BannerAllocation form from post to get.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links