Last modified: 2012-09-27 14:57:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32324, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 30324 - AbuseFilter: blocking issues
AbuseFilter: blocking issues
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
AbuseFilter (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-11 11:49 UTC by MA
Modified: 2012-09-27 14:57 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description MA 2011-08-11 11:49:54 UTC
Hello. When AbuseFilter blocks an user that triggers a filter, the filter does not seem to allow talk page access so it's imposible for IP addresses blocked to even appeal this automatic block. The fact that blocked users are not allowed to use talk page access is not noted, either, in the block log but on the Special:BlockList page. Please compare:

* BlockLog: <http://es.wikibooks.org/w/index.php?title=Especial%3ARegistro&type=block&user=&page=User%3A201.241.168.102+&year=&month=-1&tagfilter=>

* IPBlockList entry: 00:28, 11 August 2011, Filtro antiabusos (Talk | contribs | block) blocked 201.241.168.102 (Talk) (expires on 12 August 2011 at 00:28, anon. only, account creation blocked, cannot edit own talk page) (Bloqueado automáticamente por el filtro antiabusos. Descripción del filtro que se ha disparado: Vandalismo corriente #1) (unblock | change block)

So in the block log appears that the IP is hardblocked (the "block anonymous users only" box unchecked) and that talk page access is allowed. Yet, on the BlockList the IP appears blocked with anonymous users only, account creation disabled and talk page blocked.

The filter should hardblock IPs but allow talk page access. The "angry-autoblock" for IPs makes no sense.

As for registered users: account creation blocked, autoblock and angry autoblock, but talk page access allowed.

Hope that its clear otherwise please ask. Maybe this can help <http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/AbuseFilter/AbuseFilter.class.php?view=markup&pathrev=90285> [line 1011 & ss.]

Regards.
Comment 1 MA 2011-12-29 11:35:24 UTC
Another example from today:

Special:Log/block @ eswikibooks

* (show/hide) 00:16, 29 December 2011 Filtro antiabusos (Talk | contribs | block) blocked Sindinero (Talk | contribs) with an expiry time of 24 hours (account creation disabled, angry-autoblock) ‎ (Bloqueado automáticamente por el filtro antiabusos. Descripción del filtro que se ha disparado: Vandalismo corriente #1) (unblock | change block) 

Special:Blocklist

* 00:16, 29 December 2011 || Sindinero (Talk | contribs) || 00:16, 30 December 2011 (unblock | change block) || Filtro antiabusos (Talk | contribs | block) || account creation blocked, autoblock disabled, cannot edit own talk page

Messages in both logs do not match. Desired settings not applied. Thanks.
Comment 2 Jasper Deng 2012-07-25 17:45:14 UTC
A real angry autoblock should be implemented, or a normal autoblock done instead.
Comment 3 Alex Monk 2012-07-25 18:41:35 UTC
Gerrit change #16650
Comment 4 MA 2012-09-09 08:23:57 UTC
(In reply to comment #3)
> Gerrit change #16650

Are autoblocks enabled there? From what I can see it's only enabled "nocreate" and $block->isHardblock( false );

Thanks.
Comment 5 Alex Monk 2012-09-09 12:44:23 UTC
Doesn't look like it. Should it be?
Comment 6 MA 2012-09-09 13:00:11 UTC
(In reply to comment #5)
> Doesn't look like it. Should it be?

Yes please. Vandal blocks without autoblock are useless. The settings for account blocks should at least be: account creation blocked + autoblock. For IP addresses anon. only and account creation disabled.

Regards.
Comment 7 Alex Monk 2012-09-16 14:53:21 UTC
Merged by Werdna.
Comment 8 MA 2012-09-21 13:55:06 UTC
Doesn't seem resolved. Logs still show innacurate information:

<https://es.wikibooks.org/w/index.php?title=Especial:Registro/block&page=Usuario%3A190.110.152.19>

* (show/hide) 05:48, 21 September 2012 Filtro antiabusos (Talk | contribs | block) blocked 190.110.152.19 (Talk) with an expiry time of 24 hours (account creation disabled, autoblock) (Bloqueado automáticamente por el filtro antiabusos. Descripción del filtro que se ha disparado: Vandalismo corriente #1) (unblock | change block)

BlockList:

190.110.152.19 (Talk): anon. only, account creation disabled	

API data:

Array
(
    [query] => Array
        (
            [blocks] => Array
                (
                    [0] => Array
                        (
                            [id] => 1204
                            [user] => 190.110.152.19
                            [userid] => 0
                            [by] => Filtro antiabusos
                            [byid] => 40896
                            [timestamp] => 2012-09-21T05:48:46Z
                            [expiry] => 2012-09-22T05:48:46Z
                            [reason] => Bloqueado automáticamente por el filtro antiabusos. Descripción del filtro que se ha disparado: Vandalismo corriente #1
                            [rangestart] => 190.110.152.19
                            [rangeend] => 190.110.152.19
                            [anononly] => 
                            [nocreate] => 
                            [allowusertalk] => 
                        )

                )

        )

)

So, still Special:Log/block shows an info, and Special:BlockList shows another info. Blocklist info is the accurate one but it'll help if *both* logs showed the same accurate info. Also "autoblock" in Special:Log/block is not needed. Thanks.
Comment 9 MA 2012-09-21 14:33:22 UTC
Possible solution:

In Gerrit change #16650  $logParams[] = 'nocreate, angry-autoblock'; was changed to  $logParams[] = 'nocreate, autoblock';

$logParams[] looks to be used in Special:Log/block. The 'autoblock' param should be removed from that, being  $logParams[] = 'nocreate'; to avoid the weird "autoblock" message (not the option) being set in the message.

Do we have a different messages in AbuseFilter.class.php for IP blocks and username blocks?
Comment 10 Alex Monk 2012-09-21 15:25:52 UTC
Okay, it looks like I misunderstood the log parameters. Gerrit change #24552
Comment 11 MA 2012-09-23 09:52:47 UTC
And speaking about blocks, bug 30024. Thanks.
Comment 12 Alex Monk 2012-09-23 19:20:13 UTC
Merged by Siebrand.
Comment 13 MA 2012-09-27 14:34:18 UTC
Still not working - Today:

https://es.wikibooks.org/w/index.php?title=Especial%3ARegistro&type=block&user=&page=User%3A85.91.89.62&year=&month=-1&tagfilter=&uselang=en

Real block settings:

[user] => 85.91.89.62
[anononly] => 
[nocreate] => 
[allowusertalk] => 

So the block settings are applied correctly, but logging is still wrong in Special:Log/block.

I'm not setting to REOPENED now since I don't know if your patch is now "live" or is still waiting. Please change it to reopened if that already happened since the bug is still present, then.

Thank you.
Comment 14 Alex Monk 2012-09-27 14:42:08 UTC
(In reply to comment #13)
> I'm not setting to REOPENED now since I don't know if your patch is now "live"
> or is still waiting. Please change it to reopened if that already happened
> since the bug is still present, then.

The bug in AbuseFilter is fixed (I think). Whether it's deployed on WMF sites or not is a different matter.
Comment 15 Alex Monk 2012-09-27 14:57:25 UTC
It doesn't seem to be deployed, no.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links