Last modified: 2011-08-15 22:22:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32349, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 30349 - Please pull secret and/or configurable elements out of SwiftMedia/wmf/rewrite.py
Please pull secret and/or configurable elements out of SwiftMedia/wmf/rewrite.py
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Russ Nelson
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-12 19:50 UTC by Ben Hartshorne
Modified: 2011-08-15 22:22 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ben Hartshorne 2011-08-12 19:50:33 UTC
Please put the following bits into a configuration file* to make managing the extension with puppet easier:
* all the AUTH strings (lines 16, 23)
* the host for the thumb media store (line 130)
Comment 1 Russ Nelson 2011-08-15 22:22:38 UTC
The account is never going to change. It's the owner of the files in the Swift store. But still, why not put it in a config?

The auth string is a sample, since the variable is immediately overwritten by None. I deleted it.

But I also noticed the user-agent. I don't want to break the wiki by playing with it, but it should probably be settable to something other than Mozilla/5.0.

There's now a file called config.py which holds three config variables. It's running on alsted now. I'll check it in when I'm finished with other changes.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links