Last modified: 2011-08-17 14:50:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32391, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 30391 - Broken messages in the protection form


Summary:	Broken messages in the protection form

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Page protection (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized minor with 1 vote (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	easy, patch, patch-need-review

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-08-16 09:11 UTC by Mormegil
Modified:	2011-08-17 14:50 UTC (History)
CC List:	1 user (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Two message existence checks are inverted (894 bytes, patch) 2011-08-16 09:11 UTC, Mormegil	Details
Add an attachment (proposed patch, testcase, etc.)

Description Mormegil 2011-08-16 09:11:02 UTC

Created attachment 8921 [details]
Two message existence checks are inverted

r80248 broke messages on page protection forms by inverting two message existence checks.

The result is that protection levels are all displayed as “Require "X" permission” (not mentioning what would happen for custom protection levels…), and fieldset legends list the action identifier instead of their localized meaning.

See the attached patch for a fix.

Comment 1 Mark A. Hershberger 2011-08-17 01:25:08 UTC

Fixed in r80341, r80408, and r80252.

Comment 2 Mormegil 2011-08-17 08:58:58 UTC

(In reply to comment #1)
> Fixed in r80341, r80408, and r80252.

No, not fixed, not in those revisions, and not anywhere else.

Would you please see the patch, notice it is for ProtectionForm.php, and verify that none of those revisions touched this file? Or you might just take a look at the current http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/ProtectionForm.php?view=markup#l360 and realize that

  $msg->exists() ? $action : $msg->text()

is _really_ a strange logic. Or maybe just look at a live protection form on a trunk MediaWiki and see the broken behavior?

Comment 3 Mormegil 2011-08-17 14:50:19 UTC

Fixed in r94761.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links