Last modified: 2014-08-05 09:24:27 UTC
Hi. The form popup does not work with IE7. I just get an empty white box. Unfortunately, one in 11 people round the world still use IE7, so this is pretty important. I'm running MW 1.16.5 and SF 2.2. Thanks.
Adding Stephan to CC list (he should probably be the assignee, actually), since he knows all the Javascript stuff.
Just tinkered with the popup for another bug. Tested it with IE9 in IE7 mode and it seemed to work. Could you try if it works for a real IE7?
Hi. Good news. Sure, I can check it. Is it a simple change that could be posted here? I could check out the entire SF svn branch, but this might break other things and it's a question of time. Thanks!
It should be sufficient to replace ../SemanticForms/libs/SF_popupform.js. You might wait a bit longer, though. I had to do some more changes, which I will check in tonight. (Can't do it from here.) I'll let you know.
Okay, I'll wait for the check in. Thanks!
Ok, I'm finished, I hope. If you want to give it a try please replace ../SemanticForms/libs/SF_popupform.js and ../SemanticForms/skins/SF_popupform.css. Cheers.
Hi. Bad news I'm afraid. The popups do not work at all now. I just get the spinning circle. Firebug shows the following output: content.css({margin: 0, padding: padding, width: "auto", height: "auto", minWidth: "0px", minHeight: "0px", border: "none"}).parentsUntil is not a function error source line: [Break On This Error] .parentsUntil('html') SF_popupform.js (line 241) Cheers Neill.
You mean it does not even work for other browsers? There must be something else going wrong then. parentsUntil is in jQuery since 1.4, SF 2.2 ships jQuery 1.4.2 so it should definitely be in. Could you set $.fn.jquery as a watch expression in Firebug, please, and report the result? Also, is there anything else unusual on your wiki (custom skin, extensions, JS widgets)? (If you could reproduce this on a public wiki that would of course help, too.)
It's not working with any browser. I've tried Chrome 12, FF 6.0.2, IE7 & 9, Dolphin. Same result. With SF 2.2.1 it all works fine in these browsers (except in IE7 of course!) If I add a new watch expression in Firebug on $.fn.jquery I get TypeError: $.fn is undefined Perhaps just replacing those two files isn't enough and I need the whole branch?
Interestingly, if I copy just the css file then the popup works in IE7. So your CSS tweak is enough :) Worrying that the .js file causes a break though, but perhaps like I say I need the whole branch and not just those 2 files. Cheers Neill.
Those two files should be enough. The change to SF_popupform.js was necessary because in newer versions of FF scrolling did not work anymore. What happens if you watch jQuery.fn.jquery?
Interesting jQuery.fn.jquery returns "1.3.2". I did a grep and found that SRF Exhibit was using jquery-1.3.2. I updated it to 1.4.2 and the popup now works in FF and Chrome :) Exhibit seems to still function okay (which is a miracle in itself!). So I guess SRF Exhibit's jquery needs updating or a lot of people are going to see a break when this new version of SF goes live. Now the bad news. The popup now doesn't work at all in IE7. The error is: Line: 228 Char 3 Error: Object doesn't support this property or method If I revert to the 2.2.1 SF_popupform.js with the svn SF_popupform.css file it works. So something in the new js breaks IE7 completely.
Ok, I guess I have to find a real IE7 to fix this. This will take some time, though, so if applying only the CSS works for you, please do this for the time being. (Adding Jeroen to the CC list. Maybe he can fix Exhibit with a newer jQuery lib.)
I have VMWare Workstation so can fire up just about anything for testing :) IE7 is such a pain. To quote from Die Hard - "Why won't you just die!" Thanks for all your help so far.
Recent fix seem to have sorted this.
