Last modified: 2011-08-25 13:37:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32398, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 30398 - Unclickable URLs in IRC feed when using protocol relative URLs
Unclickable URLs in IRC feed when using protocol relative URLs
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-16 16:34 UTC by Siebrand Mazeland
Modified: 2011-08-25 13:37 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Siebrand Mazeland 2011-08-16 16:34:15 UTC
When using protocol relative URLs, the links in IRC are also protocol relative and not clickable.


See for example #betawiki-rc on Freenode IRC. Example line:

---
[[MediaWiki:Code-browsing-path/zh-hans]]  //translatewiki.net/w/i.php?diff=3182911&oldid=2131330 * Username * (+0)

---

Relevant code is near line 700 in includes/RecentChange.php:  http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/RecentChange.php?view=annotate
Comment 1 Roan Kattouw 2011-08-17 14:19:34 UTC
Fixed in r94754 and deployed to the Wikimedia cluster. This bug was also affecting the IRC feeds for testwiki and wikimania2005wiki.
Comment 2 Siebrand Mazeland 2011-08-17 16:22:31 UTC
Now showing clickable URLs. Thanks!

I see that the URLs are now http (only?). Is it possible to make them https, too?
Comment 3 Roan Kattouw 2011-08-17 18:51:24 UTC
(In reply to comment #2)
> Now showing clickable URLs. Thanks!
> 
> I see that the URLs are now http (only?). Is it possible to make them https,
> too?
Hashar mentioned a similar thing on CodeReview: what if the wiki only supports HTTPS?

I'll add a config option later that allows you to specify whether you want to use HTTP or HTTPS here.
Comment 4 Krinkle 2011-08-24 23:13:01 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > Now showing clickable URLs. Thanks!
> > 
> > I see that the URLs are now http (only?). Is it possible to make them https,
> > too?
> Hashar mentioned a similar thing on CodeReview: what if the wiki only supports
> HTTPS?
> 
> I'll add a config option later that allows you to specify whether you want to
> use HTTP or HTTPS here.

Seems to be done by r94995. Reminder.
Comment 5 Roan Kattouw 2011-08-25 13:37:14 UTC
(In reply to comment #4)
> Seems to be done by r94995. Reminder.
Yes, r94995 had this effect by introducing $wgCanonicalServer

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links