Last modified: 2014-11-15 12:04:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32433, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 30433 - LocalisationUpdate fails for empty message files
LocalisationUpdate fails for empty message files
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
LocalisationUpdate (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
aklapper-moreinfo
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-17 23:01 UTC by Robin Pepermans (SPQRobin)
Modified: 2014-11-15 12:04 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Robin Pepermans (SPQRobin) 2011-08-17 23:01:24 UTC
When a message file is empty (e.g. when deliberately adding an empty file to make LocalisationUpdate add that language), it fails.

I tried adding an empty $messages = array(); but even that gives a warning. Then I get:

--------------------

PHP Warning:  array_merge(): Argument #1 is not an array in C:\wamp\www\mw\exten
sions\LocalisationUpdate\LocalisationUpdate.class.php on line 367
PHP Stack trace:
PHP   1. {main}() C:\wamp\www\mw\extensions\LocalisationUpdate\update.php:0
PHP   2. LocalisationUpdate::updateMessages() C:\wamp\www\mw\extensions\Localisa
tionUpdate\update.php:32
PHP   3. LocalisationUpdate::updateMediawikiMessages() C:\wamp\www\mw\extensions
\LocalisationUpdate\LocalisationUpdate.class.php:58
PHP   4. LocalisationUpdate::compareFiles() C:\wamp\www\mw\extensions\Localisati
onUpdate\LocalisationUpdate.class.php:175
PHP   5. array_merge() C:\wamp\www\mw\extensions\LocalisationUpdate\Localisation
Update.class.php:367

Warning: array_merge(): Argument #1 is not an array in C:\wamp\www\mw\extensions
\LocalisationUpdate\LocalisationUpdate.class.php on line 367

Call Stack:
    0.0019     642296   1. {main}() C:\wamp\www\mw\extensions\LocalisationUpdate
\update.php:0
    0.2241   16614104   2. LocalisationUpdate::updateMessages() C:\wamp\www\mw\e
xtensions\LocalisationUpdate\update.php:32
    0.2241   16614344   3. LocalisationUpdate::updateMediawikiMessages() C:\wamp
\www\mw\extensions\LocalisationUpdate\LocalisationUpdate.class.php:58
   53.3661   17563600   4. LocalisationUpdate::compareFiles() C:\wamp\www\mw\ext
ensions\LocalisationUpdate\LocalisationUpdate.class.php:175
   54.2947   17796048   5. array_merge() C:\wamp\www\mw\extensions\LocalisationU
pdate\LocalisationUpdate.class.php:367

PHP Warning:  array_diff_assoc(): Argument #2 is not an array in C:\wamp\www\mw\
extensions\LocalisationUpdate\LocalisationUpdate.class.php on line 370
PHP Stack trace:
PHP   1. {main}() C:\wamp\www\mw\extensions\LocalisationUpdate\update.php:0
PHP   2. LocalisationUpdate::updateMessages() C:\wamp\www\mw\extensions\Localisa
tionUpdate\update.php:32
PHP   3. LocalisationUpdate::updateMediawikiMessages() C:\wamp\www\mw\extensions
\LocalisationUpdate\LocalisationUpdate.class.php:58
PHP   4. LocalisationUpdate::compareFiles() C:\wamp\www\mw\extensions\Localisati
onUpdate\LocalisationUpdate.class.php:175
PHP   5. array_diff_assoc() C:\wamp\www\mw\extensions\LocalisationUpdate\Localis
ationUpdate.class.php:370

Warning: array_diff_assoc(): Argument #2 is not an array in C:\wamp\www\mw\exten
sions\LocalisationUpdate\LocalisationUpdate.class.php on line 370

Call Stack:
    0.0019     642296   1. {main}() C:\wamp\www\mw\extensions\LocalisationUpdate
\update.php:0
    0.2241   16614104   2. LocalisationUpdate::updateMessages() C:\wamp\www\mw\e
xtensions\LocalisationUpdate\update.php:32
    0.2241   16614344   3. LocalisationUpdate::updateMediawikiMessages() C:\wamp
\www\mw\extensions\LocalisationUpdate\LocalisationUpdate.class.php:58
   53.3661   17563600   4. LocalisationUpdate::compareFiles() C:\wamp\www\mw\ext
ensions\LocalisationUpdate\LocalisationUpdate.class.php:175
   54.3005   17797480   5. array_diff_assoc() C:\wamp\www\mw\extensions\Localisa
tionUpdate\LocalisationUpdate.class.php:370

-----------------

When adding one message in the messages array, it works.
Comment 1 Robin Pepermans (SPQRobin) 2011-09-04 15:46:13 UTC
This seems to have worked for r94830. Using qug as interface language on WMF wikis worked.
Comment 2 Niklas Laxström 2014-03-21 08:52:16 UTC
Could you provide more detailed steps to reproduce?
Comment 3 Andre Klapper 2014-10-16 12:50:26 UTC
SPQRobin: Could you provide more detailed steps to reproduce?
Comment 4 Andre Klapper 2014-11-15 12:04:31 UTC
SPQRobin: Could you provide more detailed steps to reproduce?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links