Last modified: 2011-08-24 21:41:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32499, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 30499 - Create jQuery replacements for injectSpinner and removeSpinner
Create jQuery replacements for injectSpinner and removeSpinner
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: John Du Hart
: patch, patch-reviewed
Depends on:
Blocks: 29714
  Show dependency treegraph
 
Reported: 2011-08-22 04:00 UTC by John Du Hart
Modified: 2011-08-24 21:41 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Spinner plugin (1.56 KB, patch)
2011-08-22 04:05 UTC, John Du Hart
Details

Description John Du Hart 2011-08-22 04:00:29 UTC
Right now there is no jQuery compatible replacement for /(inject|remove)Spinner/

Do it right now!
Comment 1 John Du Hart 2011-08-22 04:05:53 UTC
Created attachment 8957 [details]
Spinner plugin

Add a spinner after an element

> $( '#mw-abusefilter-syntaxcheck' ).injectSpinner( 'abusefilter-syntaxcheck' );

Create a spinner element and return it

> $.createSpinner( 'abusefilter-syntaxcheck' );

Remove a spinner element

> $.removeSpinner( 'abusefilter-syntaxcheck' );
Comment 2 Brion Vibber 2011-08-23 18:13:27 UTC
So FYI there are already jquery spinner plugins in MwEmbed and UploadWizard.

Can we just pick one? :)
Comment 3 John Du Hart 2011-08-24 21:11:18 UTC
Applied in r95445

To be honest I did look at those 2 implementations but I didn't feel they were general enough, and were both sort of odd. This is a direct replacement for injectSpinner found in wikibits.js, and will aid in developers who are making a transition from old style JS to use jQuery.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links