Last modified: 2011-08-26 03:40:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32531, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 30531 - Pages transcluded as editintro ignore <noinclude>
Pages transcluded as editintro ignore <noinclude>
Status: NEW
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-23 20:04 UTC by Jon Harald Søby
Modified: 2011-08-26 03:40 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jon Harald Søby 2011-08-23 20:04:21 UTC
When a page that has <noinclude> in it is used as &editintro=, even the content inside <noinclude> tags is also shown as part of the editintro message. Editintro should obey <noinclude> and <includeonly> tags. This is illogical and should be changed.

Will add an example later.
Comment 1 Brion Vibber 2011-08-23 20:29:32 UTC
I'd expect to see material in <noinclude> and not see material that's in <includeonly>, since the page text is being *displayed* not transcluded as a template.

Can you confirm this is what you see?
Comment 2 Jon Harald Søby 2011-08-23 22:24:23 UTC
Yes, that is correct.

See an example here: http://meta.wikimedia.org/wiki/User:Jsoby?action=edit&editintro=User:Jsoby/Test

That makes more sense now, but is still a bit unintuitive in my opinion; There should be a way to have text there that is only displayed when the editintro-included page is shown by itself, while excluding that text when it is included as editintro. Basically, treat the editintro-ed text as a template.
Comment 3 Bawolff (Brian Wolff) 2011-08-23 22:31:59 UTC
Note: I changed the behaviour of editintro to do what Jon Harald Søby is suggesting be done in r80434 mostly because some users wanted to put interlanguage links on editintro's in <noinclude> sections without them going on to the actual edit pages. Comment 1 makes it sound like that may not have been a good change? I personally think treating it like a template is much more intuitive than the opposite behaviour.
Comment 4 Mark A. Hershberger 2011-08-25 16:02:51 UTC
I would back out the change since it is likely to later get FIXME'd.  I imagine people are already relying on the non-intuitive behavior.
Comment 5 Bawolff (Brian Wolff) 2011-08-26 03:40:38 UTC
(In reply to comment #4)
> I would back out the change since it is likely to later get FIXME'd.  I imagine
> people are already relying on the non-intuitive behavior.

I really don't think they are. The current behaviour isn't very useful. Wikipedia uses a {{#ifeq:{{FULLPAGENAME}}|<actual page name>|doc stuff that'd normally be noinclude|includeonly stuff}} (see [[template:Editintro_documentation]] for example)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links