Last modified: 2011-08-25 18:04:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32532, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 30532 - Provide a way to avoid conversion of r999 to a link on bugzilla
Provide a way to avoid conversion of r999 to a link on bugzilla
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Bugzilla (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Bugmeister Bot
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-23 20:48 UTC by Helder
Modified: 2011-08-25 18:04 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Helder 2011-08-23 20:48:12 UTC
I would like to have some way to avoid the conversion of r20 to a link for a code revision (something similar to a <nowiki> tag) in specific parts of a bug report (such as [1]). 

Is that possible?

[1] https://bugzilla.wikimedia.org/show_bug.cgi?id=30441#c2
Comment 1 Helder 2011-08-23 20:48:36 UTC
Test: foo1 bar1 baz1.
Comment 2 Helder 2011-08-23 20:51:28 UTC
Notice that in my previous comment there is an "r1" which shouldn't be converted at all, since it is not a "word". A regular expression such as "\br(\d+)\b" would match only the desired cases, I think (although I don't know if the conversion of links is done by means of regexes - BTW: where can I find the source code of this?).
Comment 4 Helder 2011-08-24 20:42:44 UTC
(In reply to comment #3)
> http://svn.wikimedia.org/viewvc/mediawiki/trunk/tools/bugzilla/bugzilla-4.0/extensions/Wikimedia/Extension.pm?view=markup

Thanks!

I'm pretty sure the regex "qr{\br(\d+)\b}" can be used instead of the current "qr{r(\d+)}" to avoid the unwanted conversion of variable names to links for MW code revisions.

Should I fork this request to a new bug?
Comment 5 Mark A. Hershberger 2011-08-25 16:05:36 UTC
(In reply to comment #4)
> Should I fork this request to a new bug?

Yes.  Closing this one since it has been solved (if not yet deployed).
Comment 6 Helder 2011-08-25 17:07:56 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > Should I fork this request to a new bug?
> 
> Yes.  Closing this one since it has been solved (if not yet deployed).

Sorry, but what has been solved?
Comment 7 Mark A. Hershberger 2011-08-25 18:04:24 UTC
Brion patched the code.  Even if that doesn't fix the problem after
the code has been deployed, then this bug is really a duplicate of
Bug #29039 which already has a fix ready as well.  I haven't had time
to update the code, though since I wanted to test it some more for
possible XSS.

Until we're willing to make each bug's comment editable in the wiki
way (something else people have asked for repeatedly), I don't think
we're going to implment <nowiki>.

There is an actual bug here, and a fix to that bug has been made.
But, if you feel the bug can't be marked “FIXED” until you can use
<nowiki>, then this is probably going to get WONTFIXed.

If that is what you want, I think filing a bug against bugzilla itself
(https://bugzilla.mozilla.org/enter_bug.cgi?format=guided#h=dupes|Bugzilla)
is going to be what you want.

(Um… sorry for the essay. :P )

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links