Last modified: 2012-07-30 17:53:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32541, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 30541 - $wgUseTidy = true in LocalSettings.php breaks video tags output
$wgUseTidy = true in LocalSettings.php breaks video tags output
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
TimedMediaHandler (Other open bugs)
unspecified
All All
: Normal critical with 1 vote (vote)
: ---
Assigned To: Michael Dale
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-24 10:36 UTC by Dmitriy Sintsov
Modified: 2012-07-30 17:53 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dmitriy Sintsov 2011-08-24 10:36:21 UTC
I've spent few hours trying to guess why Extension:TimedMediaHandler failed to display video media handler with MW 1.17, in FF 6.0 (which should have native player!). Figured out the site has $wgUseTidy = true and also set up to use external tidy.

I guess Extension:TimedMediaHandler should either throw an exception when $wgUseTidy == true, or should temporarily disable it. I better like the first approach (an exception).
Comment 1 Michael Dale 2011-08-24 17:07:14 UTC
Is this issue present in trunk mediaWiki?  Is there anything we can do to fix tidy to not mess with escaped html a data-key attribute? 

It seems like this could potentially break other components that think they are outputting "escaped" html?
Comment 2 Brion Vibber 2011-08-24 18:51:42 UTC
What exactly is it doing to the markup that's problematic? There's no mention above.

Did you check if tidy's configuration options can be tweaked?
Comment 3 Dmitriy Sintsov 2011-08-25 11:05:40 UTC
In LocalSettings.php I've had the following settings:
# $wgUseTidy = true;
# $wgTidyInternal = false;
$wgAlwaysUseTidy = false;
$wgTidyBin = '/usr/bin/tidy';

When the lines starting with dash sign were NOT commented out, Extension:TimedMediaHandler reported with local Russian 'timedmedia-no-player-js' message, which was very surprising as the browser was FF 6.0.

I have the following versions of tidy installed at the hosting:
tidy -v
HTML Tidy for Linux/x86 released on 11 February 2007

and this at the local box:
tidy -v
HTML Tidy for Linux/x86 released on 14 June 2007

both seems to don't like video tag.

The following media code string was generated in the extension:

<video id="mwe_player_0" style="width:320px;height:240px" width="320" height="240" poster="/images/thumb/f/f2/Apollo_15_launch.ogg/320px--Apollo_15_launch.ogg.jpg" a
lt="Apollo 15 launch.ogg" controls="true" class="kskin" data-durationhint="73.6736" data-startoffset="0" data-mwtitle="Apollo_15_launch.ogg" data-mwprovider="local"><source src="/images/f/f2/Apollo
_15_launch.ogg" title="Original ogg, 320 × 240 (148kbps)" data-shorttitle="Ogg source" data-width="320" data-height="240" data-bandwidth="147562" data-framerate="29.97002997003"></source>К сожалени
ю, в вашем браузере отключён JavaScript, или не имеется требуемого проигрывателя.<br />
Вы можете <a href="/images/f/f2/Apollo_15_launch.ogg">загрузить ролик</a> или <a href="http://www.mediawiki.org/wiki/Extension:OggHandler/Client_download">загрузить проигрыватель</a> для воспроизве
дения ролика в браузере.</video>

however, the output page had only local 'timedmedia-no-player-js' message, without the video tag.

I can build a test case a bit later, if this information is not sufficient enough.
Comment 4 Jan Gerber 2012-05-02 12:04:17 UTC
$wgUseTidy = true;
is enabled in production, this breaks embedding in wiki pages.
i.e. http://en.wikipedia.beta.wmflabs.org/wiki/User:J
Comment 5 alex.goldney 2012-05-03 06:41:05 UTC
This is definitely present in Turnkey MediaWiki

MediaWiki 	1.15.1
PHP 	5.3.2-1ubuntu4.10 (apache2handler)
MySQL 	5.1.41-3ubuntu12.8

When editing any page with images (using the Rich Editor) - it strips all text after the Image: tag, leaving you with [[Image:]]

This appears to be very similar to an old bug 

(http://dev.fckeditor.net/ticket/2624)
Comment 6 Mark A. Hershberger 2012-05-03 16:58:11 UTC
(In reply to comment #5)
> This is definitely present in Turnkey MediaWiki
> 
> MediaWiki     1.15.1
> PHP     5.3.2-1ubuntu4.10 (apache2handler)
> MySQL     5.1.41-3ubuntu12.8

Do you mean http://www.turnkeylinux.org/mediawiki ?

1.15 isn't supported by MediaWiki core any more.  I'll try to contact the developers of TurnKey Linux.

CCing dzahn since we've been talking about this.
Comment 7 Jan Gerber 2012-07-30 17:53:12 UTC
$wgUseTidy = true; works with TMH / core from git, so closing this bug.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links