Last modified: 2012-09-14 16:13:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32600, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 30600 - Interwiki extension's "URL" field doesn't validate input


Summary:	Interwiki extension's "URL" field doesn't validate input

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	Interwiki (extension) (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Amir E. Aharoni

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-08-28 01:57 UTC by MZMcBride
Modified:	2012-09-14 16:13 UTC (History)
CC List:	6 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
fixes the regression about interwiki name not displayed in the edit-form (388 bytes, patch) 2012-09-14 10:24 UTC, drzraf	Details
Add an attachment (proposed patch, testcase, etc.)

Description MZMcBride 2011-08-28 01:57:49 UTC

The Interwiki extension's "URL" field doesn't check against the list of $wgUrlProtocols when URLs are added or edited. It should validate input.

Comment 1 Alphos 2011-08-28 02:06:00 UTC

What if you wish to disallow gopher links, while keeping the possibility to link to a specific domain via gopher ?
Same goes with other protocols, obviously…

Comment 2 MZMcBride 2011-08-28 02:10:47 UTC

(In reply to comment #1)
> What if you wish to disallow gopher links, while keeping the possibility to
> link to a specific domain via gopher ?

Then you're being rather silly, in my opinion.

Comment 3 Amir E. Aharoni 2012-08-01 10:05:49 UTC

A patch: https://gerrit.wikimedia.org/r/#/c/17170 .

Comment 4 drzraf 2012-09-14 10:24:09 UTC

Created attachment 11110 [details]
fixes the regression about interwiki name not displayed in the edit-form

The previous patch brought in a regression, the interwiki prefix is not displayed anymore in the "edit" form.
The attached patch attempt to fix this by introducing $prefixElement in the "edit" code path too.

Comment 5 Amir E. Aharoni 2012-09-14 13:05:44 UTC

Thanks a lot for the patch! I submitted it for review in Gerrit: https://gerrit.wikimedia.org/r/#/c/23782/ .

Comment 6 Amir E. Aharoni 2012-09-14 16:13:27 UTC

Merged.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links