Last modified: 2012-01-12 12:25:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32615, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 30615 - Inline comments don't check permissions to display comment box
Inline comments don't check permissions to display comment box
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Low major (vote)
: ---
Assigned To: Antoine "hashar" Musso (WMF)
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-08-29 16:06 UTC by John Du Hart
Modified: 2012-01-12 12:25 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description John Du Hart 2011-08-29 16:06:11 UTC 
Inline comments don't check if the user is allowed to comment before showing them the comment box
Comment 1 Antoine "hashar" Musso (WMF) 2011-08-29 16:56:00 UTC 
The best way to reproduce the issue is to try to add an inline comment while not logged in. The API does returns a success. I think it is related to the API not checking for the correct user right when adding a comment using the codereviewupdate action.

Related bug : the JS script need to cleanly handle API errors (it does not do anything right now).
Comment 2 Antoine "hashar" Musso (WMF) 2011-09-03 09:13:39 UTC 
r96173 add a check in the API coderevisionupdate. If user is not allowed to post comment, it will show up an error box with the API error message.

Still need to check userright using javascript. Not sure how to do it though :(
Comment 3 Antoine "hashar" Musso (WMF) 2011-11-10 10:06:38 UTC 
lowering priority of CodeReview bugs I have opened or that are assigned to me.
Comment 4 Antoine "hashar" Musso (WMF) 2012-01-12 12:25:24 UTC 
feature reverted in core
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links