Last modified: 2011-08-29 17:32:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32617, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 30617 - Inline comments forms cannot always be closed
Inline comments forms cannot always be closed
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Antoine "hashar" Musso (WMF)
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-08-29 16:11 UTC by John Du Hart
Modified: 2011-08-29 17:32 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description John Du Hart 2011-08-29 16:11:26 UTC 
If you open 3 inline comment fields and try to close the first one, it will close the last form. Try again and it opens another form on top of the first one. The original cannot be closed.
Comment 1 Antoine "hashar" Musso (WMF) 2011-08-29 17:32:39 UTC 
On clicking a line, a javascript insert a <tr> element containg the
form. That <tr> did not get an unique id which caused troubles when
opening multiples inline comments.

r95680 forge an id based on the diff line it applies to which should
be unique since we only allow one comment form per line.

Thanks for the bug report!
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links