Last modified: 2011-09-01 07:32:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32647, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 30647 - Wrong email confirmation link from secure server
Wrong email confirmation link from secure server
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
SSL related (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-31 00:57 UTC by Jens K Andersen
Modified: 2011-09-01 07:32 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jens K Andersen 2011-08-31 00:57:35 UTC
The secure server currently sends out email confirmation links starting with http://en.wikipedia.org/wikipedia/en/wiki/Special:ConfirmEmail
This looks like a hodgepodge of a normal and secure link, and it gives a 404 error. It should be either
http://en.wikipedia.org/wiki/Special:ConfirmEmail
or
https://secure.wikimedia.org/wikipedia/en/wiki/Special:ConfirmEmail

Example of error:
"To confirm that this account really does belong to you and reactivate
e-mail features on Wikipedia, open this link in your browser:

http://en.wikipedia.org/wikipedia/en/wiki/Special:ConfirmEmail/264d4561c7ee43c80291dcb054d92c94"

The problem is only in mails from the secure server.
The confirmation code works when it is added to a valid url.
I found the bug while examining
http://en.wikipedia.org/wiki/Wikipedia:Help_desk#Generated_confirm_email_link_appears_to_be_broken_.28404_-_File_Not_Found.29
Comment 1 Brion Vibber 2011-08-31 17:44:41 UTC
This is probably a regression related to introduction of $wgCanonicalServer...

r95505 on 1.17wmf1, looks like r95002 on trunk.

The new code concats $wgCanonicalServer with $wgArticlePath, which fails on the secure.wikimedia.org setup where $wgArticlePath has been modified to work with the modified $wgServer.
Comment 2 MZMcBride 2011-08-31 19:15:32 UTC
Likely fixed by Roan in r95894.
Comment 3 Roan Kattouw 2011-09-01 07:32:01 UTC
Deployed fix to production, confirmed fix.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links