Last modified: 2012-12-30 15:10:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32686, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 30686 - Update GlobalUsage extension to work with merge of iwtransclusion into core
Update GlobalUsage extension to work with merge of iwtransclusion into core
Status: RESOLVED WONTFIX
Product: MediaWiki extensions
Classification: Unclassified
GlobalUsage (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-01 17:03 UTC by Sam Reed (reedy)
Modified: 2012-12-30 15:10 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2011-09-01 17:03:01 UTC
r95396 merged the iwtransclusion branch into core, bringing some somewhat duplicate code from the GlobalUsage extension

I've asked Peter about this, but it needs tidying up, due to clashing class names, and quite a lot of duplicate/only slightly modified code

The classes in question are GlobalUsageQuery in both, and then SpecialGlobalUsage in the extension and GlobalFileUsage in phase3
Comment 1 Peter Potrowl 2011-09-02 14:25:18 UTC
The plan when I was developing the iwtransclusion branch one year ago was actually to have the GlobalUsage extension built-in.

That's why I copied a lot of code from it to the core. IIRC, this code would be shared by both images global usage and templates global usage.

The idea was that templates global usage would be built-in anyway so it did not seem more expensive to have images global usage built-in as well...
Comment 2 Bryan Tong Minh 2012-12-30 15:10:19 UTC
Was reverted in r98467.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links