Last modified: 2012-04-19 21:10:40 UTC
Created attachment 9006 [details] Pass error object to dependency loader error handler. Gives the loader calls error handler callback information about what when wrong and what module had the error. We should pass error info to loading decency error handlers. Patch attached.
There is another call to error in mw.loader.using, // If any dependencies have errors execute error immediately else if ( filter( ['error'], dependencies ).length ) { if ( $.isFunction( error ) ) { error(); } } Perhaps fix that one too.
Yes we should fix both. Also note that passing in module name is not so useful since the closure scope just gives you the last instance of module when the error is called ( rather than the module in which the error occurred ) ...
Added the "patch" and "need-review" keywords; Mark hopes to get someone to review the patch soon.
Krinkle should just directly commit some variation that handles the use cases discussed on IRC and this bug.
OK. Assigning to self. Will do early next week.
Adding back the patch & need-review keywords since the patch still awaits review -- Timo, will you be getting to this in the next few months, or should we unassign it from you?
Patch applied in r107358. Also fixed it for another usage of error() that didn't pass any info.
