Last modified: 2012-04-19 21:10:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T32710, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 30710 - Split execution and definition in resource modules
Split execution and definition in resource modules
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
unspecified
All All
: Normal major (vote)
: 1.19.0 release
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-09-02 21:10 UTC by Krinkle
Modified: 2012-04-19 21:10 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Krinkle 2011-09-02 21:10:58 UTC 
As the title says. The following modules are/were affected by this quick hack pattern:

* jquery.client
* mediawiki.util
* mediawiki.page.ajaxCategories
* ..

Sort of a tracker bug, although I hope it's fixable on short notice after which new instances should not occur anymore.
Comment 1 Krinkle 2011-09-02 21:13:31 UTC 
jquery.client fixed.

Moved initialization from here [1] to here [2]

[1] r1=90605&r2=90604&pathrev=90605">http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/resources/jquery/jquery.client.js?r1=90605&r2=90604&pathrev=90605
[2] http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/resources/mediawiki.page/mediawiki.page.startup.js?revision=90605&view=markup#l1
Comment 2 Krinkle 2011-09-02 21:16:43 UTC 
mediawiki.page.ajaxCategories fixed:

initialization (call to .setup()) is now in separate init module. I didn't move it to mediawiki.page.ready or startup since ajaxCategories is not enabled by default.

http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/resources/mediawiki.page/mediawiki.page.ajaxCategories.init.js?view=markup&pathrev=93351#l1
Comment 3 Krinkle 2011-09-02 23:03:40 UTC 
mediawiki.util fixed in r96150.
Comment 4 Krinkle 2011-09-02 23:04:57 UTC 
This also makes unit testing a lot easier.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links